Allow to pass a fs module#6
Open
mszczepanczyk wants to merge 1 commit into
Open
Conversation
|
Is this for testing or production? Could you use something like |
Owner
|
Oh I think this is for production, so that a custom fs module can be passed in if the user is running on a JS unikernel or something? Or maybe I'm confusing this with a different PR... |
Author
|
@emschwartz @toolness yup I'm thinking about using this in production. It's viable to monkey patch the node fs module and replace it with a custom one but it's not very elegant and kinda dodgy. If there's a will to merge this pr I'll rebase it against newest changes and fix tests. |
Owner
|
Cool, I'm fine with merging it, though can you also document it in the README and explain a bit abut how/why one would use it? |
Author
|
@toolness ok sure |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.