Skip to content

Address PR review comments: Pydantic v2 migration, configurable delays, demo data#2

Open
toobutta with Copilot wants to merge 6 commits into
claude/geo-intelligence-platform-mvp-011CUr4JrZk1ks9t7cgNcNHFfrom
copilot/sub-pr-1
Open

Address PR review comments: Pydantic v2 migration, configurable delays, demo data#2
toobutta with Copilot wants to merge 6 commits into
claude/geo-intelligence-platform-mvp-011CUr4JrZk1ks9t7cgNcNHFfrom
copilot/sub-pr-1

Conversation

Copilot AI commented Nov 22, 2025

Copy link
Copy Markdown

Fixes three issues identified in PR review: non-functional comparison UI due to empty state, deprecated Pydantic v1 API usage with v2 installed, and hardcoded timing constants.

Changes

  • Frontend comparison page: Replace empty useState with hardcoded demo property IDs to enable query execution

    // Before: query never executes
    const [propertyIds] = useState<string[]>([])
    
    // After: query executes with demo data
    const propertyIds = ['property1', 'property2', 'property3']
  • Pydantic v2 migration: Update @validator@field_validator with correct v2 API

    # Before: deprecated v1 API
    @validator('shading_analysis', pre=True, always=True)
    def build_shading_analysis(cls, v, values):
    
    # After: v2 API with ValidationInfo
    @field_validator('shading_analysis', mode='before')
    @classmethod
    def build_shading_analysis(cls, v, info: ValidationInfo):
        values = info.data
  • Google Ads sync delay: Extract hardcoded 5s sleep to GOOGLE_ADS_SYNC_DELAY_SECONDS config setting for environment-based configuration


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

@toobutta toobutta marked this pull request as ready for review November 22, 2025 16:58
Copilot AI review requested due to automatic review settings November 22, 2025 16:58

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI and others added 5 commits November 22, 2025 17:03
… Google Ads delay

Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Copilot AI changed the title [WIP] Add foundational components for geo-intelligence platform Address PR review comments: Pydantic v2 migration, configurable delays, demo data Nov 22, 2025
Copilot AI requested a review from toobutta November 22, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants