Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
… Google Ads delay Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Co-authored-by: toobutta <203198883+toobutta@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add foundational components for geo-intelligence platform
Address PR review comments: Pydantic v2 migration, configurable delays, demo data
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three issues identified in PR review: non-functional comparison UI due to empty state, deprecated Pydantic v1 API usage with v2 installed, and hardcoded timing constants.
Changes
Frontend comparison page: Replace empty
useStatewith hardcoded demo property IDs to enable query executionPydantic v2 migration: Update
@validator→@field_validatorwith correct v2 APIGoogle Ads sync delay: Extract hardcoded 5s sleep to
GOOGLE_ADS_SYNC_DELAY_SECONDSconfig setting for environment-based configuration💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.