Skip to content

Fix random rock texture selection #514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tonihele merged 1 commit into from
Aug 9, 2026
Merged

Fix random rock texture selection #514

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/toniarts/openkeeper/view/map/MapViewController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -397,7 +397,10 @@ public void visit(Spatial spatial) {

// The principle is bit wrong, the random texture is tied to the tile, and not material etc.
// But it is probably just the tops of few tiles, so...
int tex = tile.getRandomTextureIndex();
// ROCK TOP.kmf contains 2 texture alternatives while Rock declares 3 textureFrames
// in Terrain.kwd. Wrap the third weighted slot to the default texture instead of
// trying to load the nonexistent T_Rock_Top2T_Rock_top2_2.j3m material.
int tex = Math.floorMod(tile.getRandomTextureIndex(), textures.size());
if (tex != 0) { // 0 is the default anyway
Geometry g = (Geometry) spatial;
Material m = g.getMaterial();
Expand All @@ -413,7 +416,6 @@ public void visit(Spatial spatial) {
g.setMaterial(newMaterial);
} catch (Exception e) {

// FIXME: Rock top fails, we may have a problem in the material naming
logger.log(Level.WARNING, "Failed to load a random texture to terrain id " + tile.getTerrainId() + ", texture index " + tex + "!", e);
}
}
Expand Down
Loading