chore: replace ton-assembly dependency with @ton/tasm#164
Conversation
📝 WalkthroughWalkthroughThe PR replaces ChangesTASM package migration
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 3 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (3 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/coverage/test/func-coverage.spec.ts (1)
8-8: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winAvoid the deep import here. Use
runtime.decompileCell(...)from@ton/tasmlikesrc/coverage/collect.tsdoes; this keeps the test off the package’s internal file layout.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/coverage/test/func-coverage.spec.ts` at line 8, The test is using a deep import for decompileCell, which ties it to `@ton/tasm`’s internal layout. Update func-coverage.spec.ts to import and use runtime.decompileCell from `@ton/tasm`, matching the pattern used in collect.ts, so the test relies only on the public API and not the dist/runtime path.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/coverage/test/func-coverage.spec.ts`:
- Line 8: The test is using a deep import for decompileCell, which ties it to
`@ton/tasm`’s internal layout. Update func-coverage.spec.ts to import and use
runtime.decompileCell from `@ton/tasm`, matching the pattern used in collect.ts,
so the test relies only on the public API and not the dist/runtime path.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 29ef2fed-6aa5-4885-870c-1f2cf85c9eb5
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (7)
CHANGELOG.mdpackage.jsonsrc/coverage/collect.tssrc/coverage/data.tssrc/coverage/test/asm-coverage.spec.tssrc/coverage/test/execute.tssrc/coverage/test/func-coverage.spec.ts
Issue
Closes #
Checklist
Please ensure the following items are completed before requesting review:
CHANGELOG.mdwith relevant changesREADME.mdyarn lint)Summary by CodeRabbit