Skip to content

chore: replace ton-assembly dependency with @ton/tasm#164

Merged
i582 merged 1 commit into
masterfrom
danil42russia/use_ton_tasm_dependence
Jun 27, 2026
Merged

chore: replace ton-assembly dependency with @ton/tasm#164
i582 merged 1 commit into
masterfrom
danil42russia/use_ton_tasm_dependence

Conversation

@Danil42Russia

@Danil42Russia Danil42Russia commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Issue

Closes #

Checklist

Please ensure the following items are completed before requesting review:

  • Updated CHANGELOG.md with relevant changes
  • Documented the contribution in README.md
  • Added tests to demonstrate correct behavior (both positive and negative cases)
  • All tests pass successfully
  • Code passes linting checks (yarn lint)

Summary by CodeRabbit

  • Chores
    • Updated the project to use a newer TASM package across coverage tooling and tests.
    • Adjusted dependency metadata to reflect the package change.
  • Bug Fixes
    • Corrected the changelog entry for the latest release to reference the updated package name.

@Danil42Russia Danil42Russia requested a review from i582 June 27, 2026 12:36
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The PR replaces ton-assembly with @ton/tasm in dependencies, coverage source imports, and coverage tests, and updates the 0.37.2 changelog note.

Changes

TASM package migration

Layer / File(s) Summary
Dependency update
package.json, CHANGELOG.md
ton-assembly is removed, @ton/tasm is added, and the 0.37.2 changelog entry names @ton/tasm.
Coverage import switch
src/coverage/collect.ts, src/coverage/data.ts, src/coverage/test/*
Coverage code and tests import runtime, text, trace, and decompileCell from @ton/tasm paths instead of ton-assembly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I thumped my paws and gave a cheer,
Swapped old shells for TASM near.
Coverage hops with tidy grace,
Tests keep time at rabbit pace.
🐰 Carrot confetti lights the place!

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description matches the template structure but remains a placeholder without a real issue number or completed checklist items. Replace the placeholder issue reference with the actual issue number and fill in the checklist with the relevant completed items.
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: swapping the dependency from ton-assembly to @ton/tasm.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch danil42russia/use_ton_tasm_dependence

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install failed. For unrecoverable errors, disable the tool in CodeRabbit configuration.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick comments (1)
src/coverage/test/func-coverage.spec.ts (1)

8-8: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Avoid the deep import here. Use runtime.decompileCell(...) from @ton/tasm like src/coverage/collect.ts does; this keeps the test off the package’s internal file layout.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/coverage/test/func-coverage.spec.ts` at line 8, The test is using a deep
import for decompileCell, which ties it to `@ton/tasm`’s internal layout. Update
func-coverage.spec.ts to import and use runtime.decompileCell from `@ton/tasm`,
matching the pattern used in collect.ts, so the test relies only on the public
API and not the dist/runtime path.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@src/coverage/test/func-coverage.spec.ts`:
- Line 8: The test is using a deep import for decompileCell, which ties it to
`@ton/tasm`’s internal layout. Update func-coverage.spec.ts to import and use
runtime.decompileCell from `@ton/tasm`, matching the pattern used in collect.ts,
so the test relies only on the public API and not the dist/runtime path.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 29ef2fed-6aa5-4885-870c-1f2cf85c9eb5

📥 Commits

Reviewing files that changed from the base of the PR and between f9acb17 and c452541.

⛔ Files ignored due to path filters (1)
  • yarn.lock is excluded by !**/yarn.lock, !**/*.lock
📒 Files selected for processing (7)
  • CHANGELOG.md
  • package.json
  • src/coverage/collect.ts
  • src/coverage/data.ts
  • src/coverage/test/asm-coverage.spec.ts
  • src/coverage/test/execute.ts
  • src/coverage/test/func-coverage.spec.ts

@i582 i582 merged commit 57727e7 into master Jun 27, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants