Fix V8 upgrade CI regressions across Android/Linux/Darwin - #120
Open
mjackson wants to merge 4 commits into
Open
Conversation
Owner
|
Hi. Thanks for the PR! I've been working on this in https://github.com/tommie/v8go/tree/issue-109, but haven't been able to get all platforms to run cleanly so far. Here's the latest build with Darwin failing, but Linux succeeding. Does the Android tests run cleanly? I had an issue with customcxx causing symbol mangling mismatch, so when the cgo files were compiled with system libc++, they wouldn't find any function that used e.g. Could you explain the "Disable Clang/libc++ module builds" a bit? What errors were you seeing with module builds? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR includes all build-fix commits needed for the V8 14.5.x upgrade path:
patches/20250331-stringhasher-arm64.patchbecause the fix is already upstream in V8 and the patch now fails as reversed/already-applied.deps/build.pyto avoid libc++/visibility breakages.--clangfor Linux matrix builds in.github/workflows/v8build.yml(current V8 revisions fail with GCC in CI).use_custom_libcxx=true) sostd::atomic_refis available.deps/.build/<os>_<arch>, andneeds.build_common.outputs.v8_hashplus build-script/patch fingerprints.Why
Recent V8 upgrade workflow runs have failed with:
no member named 'atomic_ref' in namespace 'std'