DRAFT / WIP: Feature/support esm - #103
Draft
stroiman wants to merge 31 commits into
Draft
Conversation
stroiman
commented
May 9, 2025
| #define ISOLATE_SCOPE(iso) \ | ||
| Locker locker(iso); \ | ||
| Isolate::Scope isolate_scope(iso); \ | ||
| HandleScope handle_scope(iso); |
Author
There was a problem hiding this comment.
I made the namespace explicit, so #includeing this file doesn't require the source file to use a namespace.
Author
|
I see my But looking at existing test test code, I see to a large part it ignores errors. And I guess that should be fine - if a v8go call returns an error, the actual test/comparison would most probably fail anyway, assuming it's not comparing with zero-values. Thought's on this? |
This tests module functionality, they just happen to be created through the script compiler.
stroiman
force-pushed
the
feature/support-esm
branch
from
May 12, 2025 04:45
608b721 to
b32069b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is far from ready to merge, I merely make this as a draft so you can check out the state of the code.
Module caching needs to be understood, I can only assume an infinite recursion would happen with cyclic deps right now.
I would also as a minimum understand how dynamic imports work, even if they might not be supported at first. Just to make sure that it can be added later without requiring a breaking change.
I'll use it in an experimental branch of https://github.com/gost-dom/browser so it has been tested in a larger context before removing "draft" status.