Add cavaquinho as a static instrument in the tester - #22
Open
rezendehugo wants to merge 2 commits into
Open
Conversation
- Import cavaquinho chords from @tombatossals/chords-db - Add cavaquinho instrument to instruments object - Configure with 4 strings and D-G-B-D tuning - Cavaquinho now appears in chord browser alongside Guitar, Ukulele, Piano Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Test that cavaquinho appears in instrument selector - Test that cavaquinho is navigable - Test all 4 instruments are rendered (Guitar, Ukulele, Piano, Cavaquinho) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
Cavaquinho preview |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds cavaquinho to the
react-chordstester as a static instrument route so the library can render and browse the new cavaquinho chord dataset.Depends on
chords-dbPR adding the cavaquinho dataset and generated JSONWhat changed
Scope
This PR is intentionally minimal and keeps upstream scope narrow:
Validation
@tombatossals/chords-dbdata