Fix PV compat crash with other improvements#988
Open
apehum wants to merge 6 commits into
Open
Conversation
Owner
|
Models were made with the expectation of the old range, so changing the logic will break old models' animations. |
This reverts commit 1aeafb0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes crash by swapping
@Injectwith@InjectPlasmoVoice:Other changes not related to crash:
AudioCaptureProcessedEventnow passes audio only when actually speaking (aka using activations).isMutednow respects client-side mutes.-AudioUtil(available in public API) is now used to calculate audio level and convert dB value to[0, 1]float range. AlthoughaudioLevelToDoubleRangeactually maps from[-60, 0]->[0, 1], so logic is not the same. But I found it more "accurate", because original[-127, 0]->[0, 1]range means that-60is0.5, which is effectively silence.