Preserve HTML in sitedownmessage when WYSIWYG is active#1
Open
Koalink wants to merge 2471 commits into
Open
Conversation
simplify db interaction
improved race-prevention for sequence-tables
use mutable profile
use user-specific preference methods
rename elements
support jobs clearing not a cached page
support usage of all profile-properties
use event-handler types
use event-handler types
add checkbox values
show error-dialog
The sitedownmessage field in Site Preferences used strip_tags() on all submitted values, stripping every HTML tag before saving. Since the field is rendered through a WYSIWYG editor, any formatting (paragraphs, line breaks, bold, links, etc.) was silently discarded, giving the impression that modifications were not persisted. Only apply strip_tags() when the WYSIWYG toggle is disabled; otherwise store the raw HTML as entered. The empty-after-trim guard is preserved so blank submissions still trigger error_sitedownmessage.
Owner
|
Thanks, I totally agree with your identification of the problem. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sitedownmessage field in Site Preferences used strip_tags() on all submitted values, stripping every HTML tag before saving. Since the field is rendered through a WYSIWYG editor, any formatting (paragraphs, line breaks, bold, links, etc.) was silently discarded, giving the impression that modifications were not persisted.
Only apply strip_tags() when the WYSIWYG toggle is disabled; otherwise store the raw HTML as entered. The empty-after-trim guard is preserved so blank submissions still trigger error_sitedownmessage.