Skip to content

feat: bump @tginternal/editor to 1.18.0 - html entity placeholder highlighting - #3766

Merged
dkrizan merged 2 commits into
mainfrom
bdshadow/html-entity-highlighting
Jul 1, 2026
Merged

feat: bump @tginternal/editor to 1.18.0 - html entity placeholder highlighting #3766
dkrizan merged 2 commits into
mainfrom
bdshadow/html-entity-highlighting

Conversation

@bdshadow

@bdshadow bdshadow commented Jun 24, 2026

Copy link
Copy Markdown
Member

This pr must go after: tolgee/editor#9 is merged and version of the editor updated.

Adds light/dark colors for the new "entity" placeholder (decoded HTML entities) rendered by @tginternal/editor, matching the tag colors but slightly lighter.

A user was complaining that translations were not readable. Now it's like this:

Screenshot 2026-06-24 at 16 29 38 Screenshot 2026-06-24 at 16 29 47

Summary by CodeRabbit

  • New Features

    • Added a new placeholder style for entities in both light and dark themes, keeping placeholder styling more consistent across the app.
  • Chores

    • Updated the editor dependency to the latest minor version for improved compatibility and maintenance.

Adds light/dark colors for the new "entity" placeholder (decoded HTML
entities) rendered by @tginternal/editor, matching the tag colors but
slightly lighter.
@bdshadow
bdshadow marked this pull request as draft June 24, 2026 20:33
@coderabbitai

coderabbitai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Adds an entity placeholder to the Placeholders type and supplies border, background, and text color values for both light and dark themes. The @tginternal/editor dependency is bumped from 1.17.0 to 1.18.0.

Entity Placeholder Colors

Layer / File(s) Summary
Entity placeholder type and theme values
webapp/src/colors.tsx, webapp/package.json
Placeholders type gains entity: Placeholder; light and dark colors objects add matching entity styling; editor package bumped to 1.18.0.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A new entity hops into the palette today,
With border and background and text on display,
Light theme and dark theme both dressed in new hue,
The editor bumped up — version fresh and brand new,
🐇✨ This rabbit approves of the colorful stew!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly reflects the main changes: bumping @tginternal/editor and adding HTML entity placeholder highlighting.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch bdshadow/html-entity-highlighting

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

The 1.18.0 release adds the "entity" placeholder that decodes and
highlights HTML entities (é,  , ...) in the translation
editor. Paired with the entity theme colors added earlier.
@bdshadow
bdshadow requested review from Anty0 and dkrizan June 30, 2026 08:55
@bdshadow
bdshadow marked this pull request as ready for review June 30, 2026 08:55
@dkrizan

dkrizan commented Jun 30, 2026

Copy link
Copy Markdown
Member

@bdshadow PR name should probably include @tginternal/editor bump

@bdshadow bdshadow changed the title feat: add entity placeholder colors to the theme palette feat: bump @tginternal/editor to 1.18.0 - html entity placeholder highlighting Jun 30, 2026
@dkrizan
dkrizan merged commit 23048d5 into main Jul 1, 2026
70 of 74 checks passed
@dkrizan
dkrizan deleted the bdshadow/html-entity-highlighting branch July 1, 2026 08:33
TolgeeMachine added a commit that referenced this pull request Jul 1, 2026
# [3.208.0](v3.207.0...v3.208.0) (2026-07-01)

### Features

* bump @tginternal/editor to 1.18.0 - html entity placeholder highlighting  ([#3766](#3766)) ([23048d5](23048d5))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants