Mat3: implemented the toString() method#76
Open
ulukbek-s wants to merge 4 commits into
Open
Conversation
* Create a test/s for a method 'toString()' to convert the matrix into a String * Pass the test/s for the 'toString()' method
2 tasks
vgzx64
approved these changes
Dec 26, 2023
IakovBubel
approved these changes
Dec 30, 2023
toksaitov
requested changes
Jan 6, 2024
Comment on lines
+62
to
+64
| return "(" + m[0] + ", " + m[1] + ", " + m[2] + ")\n" + | ||
| "(" + m[3] + ", " + m[4] + ", " + m[5] + ")\n" + | ||
| "(" + m[6] + ", " + m[7] + ", " + m[8] + ")"; |
Comment on lines
+158
to
+169
| void whenToStringCalled_thenReturnsStringRepresentation() { | ||
| var m = new Mat3( | ||
| 1.0f, 2.0f, 3.0f, | ||
| 4.0f, 5.0f, 6.0f, | ||
| 7.0f, 8.0f, 9.0f | ||
| ); | ||
| String expected = "(1.0, 2.0, 3.0)\n" + | ||
| "(4.0, 5.0, 6.0)\n" + | ||
| "(7.0, 8.0, 9.0)"; | ||
|
|
||
| assertEquals(expected, m.toString()); | ||
| } |
Owner
There was a problem hiding this comment.
Look how the Mat2 toString tests were done and do the same.
vgzx64
approved these changes
Jan 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.