Mat4: implement the mul(other: Vec4) method#73
Open
koshoev-t wants to merge 2 commits into
Open
Conversation
toksaitov
requested changes
Dec 24, 2023
| 1.0f, 2.0f, 3.0f, 4.0f, | ||
| 5.0f, 6.0f, 7.0f, 8.0f, | ||
| 9.0f, 10.0f, 11.0f, 12.0f, | ||
| 13.0f, 14.0f, 15.0f, 16.0f |
Collaborator
Author
There was a problem hiding this comment.
Please, fix the indentation
Could you please clarify what the problem with the indentation is? I checked and rechecked, and it seems consistent with the formatting of the rest of the code.
Owner
There was a problem hiding this comment.
Take a look at lines 204 and 213.
| assertEquals(70.0f, r.x()); | ||
| assertEquals(174.0f, r.y()); | ||
| assertEquals(278.0f, r.z()); | ||
| assertEquals(382.0f, r.w()); |
2 tasks
vgzx64
changed the title
Mat4: implement and test mul(other: Vec4) methodMat4: implement the mul(other: Vec4) method
toksaitov
requested changes
Jan 6, 2024
| 1.0f, 2.0f, 3.0f, 4.0f, | ||
| 5.0f, 6.0f, 7.0f, 8.0f, | ||
| 9.0f, 10.0f, 11.0f, 12.0f, | ||
| 13.0f, 14.0f, 15.0f, 16.0f |
Owner
There was a problem hiding this comment.
Take a look at lines 204 and 213.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #22