feat: Add TUI improvements including task list sorting, dynamic column resizing, and performance optimizations#620
Open
vidishagawas121 wants to merge 1 commit into
Conversation
…n resizing, and performance optimizations
hds
requested changes
Apr 8, 2025
Collaborator
hds
left a comment
There was a problem hiding this comment.
Thanks for your PR!
This one looks quite large. I think it would be better to have separate PRs. As a suggestion, perhaps split up along the lines of the 4 sections in the PR text:
- Column sort selection with mouse (sorting is already implemented)
- Column resizing
- Performance improvements
- TUI integration tests
Author
|
ok! Thanks! I will look into it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TUI (Text User Interface) Improvements
This pull request adds several improvements to make the console interface more user-friendly and efficient.
🎯 What's New
1. Task List Sorting
2. Dynamic Column Resizing
3. Performance Improvements
4. New Integration Tests
Added comprehensive tests to ensure everything works reliably:
🔍 Technical Details
Modified files:
tokio-console/src/input.rs: Added mouse event handling for column resizingtokio-console/src/state/mod.rs: Added state management for sorting and column widthstokio-console/src/state/tasks.rs: Implemented task sorting logictokio-console/src/view/mod.rs: Updated view managementtokio-console/src/view/table.rs: Added resizable column supporttokio-console/src/view/tasks.rs: Implemented sorted task rendering🧪 Testing
All new features are covered by integration tests in
tokio-console/tests/tui_integration.rs. The tests verify:📝 Notes