Fix: Parametrized bigdecimal mapping was being concatenated with params#7584
Open
themisvaltinos wants to merge 1 commit intomainfrom
Open
Fix: Parametrized bigdecimal mapping was being concatenated with params#7584themisvaltinos wants to merge 1 commit intomainfrom
themisvaltinos wants to merge 1 commit intomainfrom
Conversation
Contributor
SQLGlot Integration Test ResultsComparing:
By Dialect
Overallmain: 113236 total, 112046 passed (pass rate: 98.9%), sqlglot version: sqlglot:themis/bigdec: 109169 total, 108877 passed (pass rate: 99.7%), sqlglot version: Transitions: Dialect pair changes: 0 previous results not found, 1 current results not found ✅ 38 test(s) passed |
themisvaltinos
force-pushed
the
themis/bigdec
branch
from
40929f0 to
40c53cd
Compare
VaggelisD
reviewed
May 5, 2026
Comment on lines
+1691
to
+1692
| if not expr_nested and isinstance(type_value, exp.DType): | ||
| expression = self.datatype_param_bound_limiter(expression, type_value) |
Collaborator
There was a problem hiding this comment.
datatype_sql is hot so I think we should gate this by whether the dialect has type bounds, wdyt?
| and int(param_value.to_py()) > bound | ||
| ): | ||
| self.unsupported( | ||
| f"{type_value.value} parameter ({int(param_value.to_py())}) " |
Collaborator
There was a problem hiding this comment.
Do we need to convert to to_py() and wrap with int? Can we just let it be as param_value?
| ): | ||
| self.unsupported( | ||
| f"{type_value.value} parameter ({int(param_value.to_py())}) " | ||
| f"exceeds {self.dialect.__class__.__name__}'s maximum capping to {bound}" |
Collaborator
There was a problem hiding this comment.
Not sure if this reads well, did you mean to write it as <type> parameter exceeds dialects maximum <bound>; Capping.?
Comment on lines
+1670
to
+1677
| new_param = param.copy() | ||
| capped = exp.Literal.number(bound) | ||
| if isinstance(new_param, exp.DataTypeParam): | ||
| new_param.set("this", capped) | ||
| else: | ||
| new_param = capped | ||
| new_params[i] = new_param | ||
| changed = True |
Collaborator
There was a problem hiding this comment.
Do we need the copy here and the swap logic?
| assert expr1.meta == {} | ||
|
|
||
| def test_pipe_and_apply(self) -> None: | ||
|
|
Comment on lines
+623
to
+624
| TYPE_DEFAULT_PARAMS: t.ClassVar[dict[exp.DType, tuple[int, ...]]] = {} | ||
| TYPE_PARAM_BOUNDS: t.ClassVar[dict[exp.DType, tuple[int | None, ...]]] = {} |
Collaborator
There was a problem hiding this comment.
I wonder whether these could be a single data structure to avoid separate dict lookups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the default BIGDECIMAL to DECIMAL(38, 5) mapping was being concatenated with explicit (76, 38) params, producing DECIMAL(38, 5)(76, 38) in ducked:
added a check in
_datatype_sqlto pass through the usersupplied params when present instead and falling back to the default otherwise