fix: lazy load node-llama-cpp for no-op embed#604
Open
aceclaw826 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid importing
node-llama-cppuntil QMD actually needs a local LLM/model operation.This keeps no-op embed/status-style paths lightweight. In particular,
store.embed()already checks for pending documents before calling into the LLM, but the previous static import meant the nativenode-llama-cppmodule was still loaded as soon asllm.tswas imported.This matters for OpenClaw multi-agent gateways where boot/update cycles may call
qmd embedfrequently and most runs often have no missing embeddings.Changes
node-llama-cppvalue imports to type-only imports.node-llama-cpp.getLlama,resolveModelFile,LlamaLogLevel, andLlamaChatSessiononly from code paths that actually need them.node-llama-cpp.Related
This addresses part of openclaw/openclaw#72144: avoiding heavy native/LLM initialization when all content hashes already have embeddings.
Tests
Passed:
Also checked:
corepack pnpm exec tsc -p tsconfig.build.json --noEmitThat currently fails on main with an unrelated existing error: