This repository was archived by the owner on Apr 14, 2026. It is now read-only.
Ensure unique contexts#10
Open
chrisbreiding wants to merge 1 commit into
Open
Conversation
… contexts are unique
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found that using Math.random() to create names for contexts would occasionally cause the same name to be generated, leading to the same context being used when the desire is to have different contexts. In some instances, this causes the isolated fake to be used in the place of the code-under-test, which of course causes the test to fail.
Using an incrementing number ensures a unique name is generated and, therefore, a unique context is created as desired.