Consolidate SLE tools into unified mist_get_sle with enhancements#41
Merged
Conversation
Consolidate mist_get_org_sle, mist_get_org_sites_sle, and mist_get_site_sle into a single mist_get_sle tool with a sle_scope parameter (org|org_sites|site). - All original parameters and API calls preserved - mist_list_site_sle_info kept separate (metadata tool) - Updated tool_helper.py and README.md references Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add sle_scope=site_metrics and sle_scope=site_classifiers to the unified mist_get_sle tool, replacing the separate mist_list_site_sle_info tool. All 4 original SLE tools are now consolidated into a single tool. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
- Update docstring to mention all 5 sle_scope values - Restore mist_get_insight_metrics hint for org-scope sle parameter Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Clarify that mxedge is valid for detailed site SLE data but not for the site_metrics or site_classifiers metadata scopes inherited from mist_list_site_sle_info. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR consolidates multiple SLE-related MCP tools into a single mist_get_sle tool (supporting org-, org-sites-, site-, and SLE-metadata queries) and updates docs/tool catalogs accordingly. It also extends mist_get_configuration_objects to cover org/site info and settings object types, and updates the MCP generator templates to produce the new consolidated tooling.
Changes:
- Replaced multiple SLE tools (
mist_get_site_sle,mist_list_site_sle_info,mist_get_org_sle,mist_get_org_sites_sle) with one consolidated tool:mist_get_sle. - Extended configuration-object retrieval types (e.g.,
org_info,org_settings,site_info,site_settings) and updated tool catalogs/docs. - Updated MCP generator templates/config to generate the consolidated SLE tool and to track operation IDs for change tools.
Reviewed changes
Copilot reviewed 17 out of 18 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/mistmcp/tools/utilities.py | Minor formatting-only changes in utilities helper logic. |
| src/mistmcp/tools/list_site_sle_info.py | Removed legacy SLE metadata tool (replaced by mist_get_sle). |
| src/mistmcp/tools/get_sle.py | Added consolidated SLE tool covering org/org-sites/site + metrics/classifiers discovery. |
| src/mistmcp/tools/get_site_sle.py | Removed legacy site SLE tool (replaced by mist_get_sle). |
| src/mistmcp/tools/get_org_sle.py | Removed legacy org SLE tool (replaced by mist_get_sle). |
| src/mistmcp/tools/get_org_sites_sle.py | Removed legacy org-sites SLE tool (replaced by mist_get_sle). |
| src/mistmcp/tools/get_org_or_site_info.py | Removed legacy org/site info tool (folded into mist_get_configuration_objects types). |
| src/mistmcp/tools/get_configuration_objects.py | Added org/site info & settings object types; updated docs/constraints text. |
| src/mistmcp/tool_helper.py | Updated tool categories to expose mist_get_sle and remove deprecated tools. |
| src/mistmcp/server.py | Updated runbook text to point to mist_get_sle for site metric discovery. |
| README.md | Updated quickstart tool list to reference consolidated mist_get_sle. |
| mcp_generator/tools_optimization.yaml | Commented out legacy SLE/info tool consolidations (superseded by new template approach). |
| mcp_generator/templates/tmpl_tool_utilities.py | Fixed escaping inside generator template output for newline joins and minor formatting. |
| mcp_generator/templates/tmpl_tool_change_configuration_objects.py | Added explicit operation-id list for change tool generation/coverage tracking. |
| mcp_generator/templates/tmpl_get_sle.py | Added generator template for consolidated mist_get_sle tool. |
| mcp_generator/templates/tmpl_get_configuration_objets.py | Updated generator template to include new org/site info/settings object types + operation IDs. |
| mcp_generator/generate_from_openapi.py | Wired generator to emit the new get_sle tool and to use change-tool operation IDs. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
… error handling for unsupported scope
- Removed the `searchGuestAuthorization` tool and integrated its functionality into the `searchClient` tool, allowing for guest and site guest searches based on client type. - Updated the `searchClient` tool to support new client types: Org guest and Site guest. - Enhanced parameter validation in `searchClient` to ensure compatibility with client types. - Deleted the `search_guest_authorization.py` file as its functionality is now handled within `searchClient`. - Updated the `tools_optimization.yaml` to reflect the changes in the client search tool and removed the deprecated guest authorization tool. - Adjusted the `McpToolsCategory` enum to include a dedicated `CLIENTS` category.
…y and consistency
…aide/merge-sle-tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.