Skip to content

Optimize nibble reversals #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
agprimatic wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Optimize nibble reversals #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/X10ex.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ bool X10ex::sendDim(uint8_t house, uint8_t unit, uint8_t percent, uint8_t repeti
return sendExt(
house, unit, brightness >> 4 ? CMD_PRE_SET_DIM_1 : CMD_PRE_SET_DIM_0,
// Reverse nibble before sending
(((brightness * 0x0802LU & 0x22110LU) | (brightness * 0x8020LU & 0x88440LU)) * 0x10101LU >> 20) & B1111, 0,
((brightness * 0x0802LU & 0x2814LU) * 0x1111LU >> 12) & B1111, 0,
repetitions);
}
}
Expand Down Expand Up @@ -600,7 +600,7 @@ void X10ex::receiveStandardMessage()
rxData =
(
// Get the four least significant bits in reverse (bit 8-5 => 1-4)
((((receiveBuffer * 0x0802LU & 0x22110LU) | (receiveBuffer * 0x8020LU & 0x88440LU)) * 0x10101LU >> 16) & B1111) +
(((receiveBuffer * 0x0802LU & 0x8140LU) * 0x1111LU >> 16) & B1111) +
// Add most significant bit (bit 1 => 5)
((receiveBuffer & B0001) << 4)
) * 2;
Expand Down Expand Up @@ -832,4 +832,4 @@ void X10ex::fastDigitalWrite(uint8_t port, uint8_t bitMask, uint8_t value)
*out |= bitMask;
}
SREG = sreg;
}
}