Skip to content

Simplistic fixes for 11.2.7, should restore full functionality#6

Open
zaphon wants to merge 1 commit into
tmg-pub:mainfrom
zaphon:main
Open

Simplistic fixes for 11.2.7, should restore full functionality#6
zaphon wants to merge 1 commit into
tmg-pub:mainfrom
zaphon:main

Conversation

@zaphon

@zaphon zaphon commented Dec 8, 2025

Copy link
Copy Markdown

No description provided.

@Zwixx

Zwixx commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

This duplicates Messages if you use multiple Chat Tabs.

@zaphon

zaphon commented Dec 17, 2025

Copy link
Copy Markdown
Author

I'll investigate later, but I don't see how anything I changed would have caused that.

@Zwixx

Zwixx commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

In my solution #5 it's working. You need a dedupe Check. Because of all Chat Windows triggers that event.

@zaphon

zaphon commented Dec 19, 2025

Copy link
Copy Markdown
Author

I'm still not sure why that's necessary (I'm not seeing duplication), but I will dig further. Thanks.

@tmg-pub

tmg-pub commented Dec 22, 2025

Copy link
Copy Markdown
Owner

Thanks for the contributions. I have not had much time for the RP scene lately so I don't know what's broken. Could you please describe what bugs have been identified and resolved with this PR? Thanks.

@zaphon

zaphon commented Dec 22, 2025

Copy link
Copy Markdown
Author

It was a much simpler (I prefer minimal) fix than Zwixx's that you already accepted. He did merge in some of my changes to his as well. Though he also left out one piece of it (the change in keywords.lua I made). I will have to test his change to see how the piece he left out works, my guess is he has another addon that's providing a stub for the old method (I purposely avoid doing that).

@zaphon

zaphon commented Dec 28, 2025

Copy link
Copy Markdown
Author

I figured out why my second change in keywords.lua isn't needed (YET), it's because there is a stub for ChatFrame_AddMessageEventFilter in the Blizzard Deprecated addon.

./Interface/AddOns/Blizzard_DeprecatedChatInfo/Deprecated_ChatFrame.lua:ChatFrame_AddMessageEventFilter = ChatFrameUtil.AddMessageEventFilter;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants