Skip to content

Fix ltfu #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeremyrcoyle wants to merge 4 commits into
base: devel
Choose a base branch
from
Open

Fix ltfu #92

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f12d0a1
use requireNamespace for optional test
MichaelChirico Mar 4, 2022
96677b3
add to Suggests
MichaelChirico Mar 4, 2022
ed72f8a
Merge pull request #81 from MichaelChirico/patch-1
jeremyrcoyle May 11, 2022
a69eac8
fix continuous under LTFU
jeremyrcoyle Aug 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions DESCRIPTION
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ Suggests:
Rsolnp,
nnls,
tmle,
tmle3shift,
future,
future.apply,
xgboost
Expand Down
4 changes: 2 additions & 2 deletions R/tmle3_Task.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ tmle3_Task <- R6Class(
if ((current_node$scale) &&
(current_type$type == "continuous") &&
(is.null(current_type$bounds))) {
min_x <- min(variable_data)
max_x <- max(variable_data)
min_x <- min(variable_data, na.rm=TRUE)
max_x <- max(variable_data, na.rm = TRUE)
range <- max_x - min_x
lower <- min_x #- 0.1 * range
upper <- max_x #+ 0.1 * range
Expand Down
168 changes: 0 additions & 168 deletions docs/reference/tmle_tsm_all.html
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions tests/testthat/test-lf_known.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ learner_list <- list(
)

# pass defined likelihood into existing spec
if (require("tmle3shift")) {
tmle_spec <- tmle_shift(
if (requireNamespace("tmle3shift", quietly = TRUE)) {
tmle_spec <- tmle3shift::tmle_shift(
shift_val = 0.5,
likelihood_override = likelihood_def
)
Expand Down