Skip to content

feat(ui): add switchable tabular view for resource bundles (1.2.0)#60

Open
Copilot wants to merge 4 commits into
masterfrom
copilot/add-table-view-switcher
Open

feat(ui): add switchable tabular view for resource bundles (1.2.0)#60
Copilot wants to merge 4 commits into
masterfrom
copilot/add-table-view-switcher

Conversation

Copy link
Copy Markdown

Copilot AI commented May 16, 2026

Adds an alternative table-based layout to the i18n editor (rows = keys, columns = locales), togglable from the form view and persisted across sessions. Bumps the plugin to 1.2.0 and integrates an Eclipse help system with comprehensive UI documentation and context-sensitive F1 help.

Changes

  • I18nTableView – new TableViewer-backed composite with a Key column plus one editable column per sorted locale. Cell edits go through BundleGroup.addBundleEntry, preserving comment/commented state and reusing existing dirty/save plumbing.
  • I18nPageEditor – wraps the i18n page in a GridLayout with a top toolbar (Form view / Table view toggles) over a StackLayout that swaps I18nPageI18nTableView. Initial selection is read from preferences; clicking a toggle writes it back. Context-sensitive F1 help is wired via PlatformUI.getHelpSystem().setHelp() for the toolbar, form view, and table view.
  • ResourceBundleEditor – holds an I18nPageEditor reference and calls a new refreshActiveView() on page change, resource-change events, and addResource(...), so the table reflects external edits and newly added locales.
  • Preferences – new TABLE_VIEW key (default false) with getTableView() / setTableView() on RBEPreferences; default registered in RBEPreferenceInitializer.
  • i18n stringseditor.view.form{,.tooltip}, editor.view.table{,.tooltip}, editor.view.table.key added to all 13 locale files (en, zh, de, es, fa, fr, it, ja, nn_NO, no, pt, zh_HK, zh_TW).
  • Versioning1.1.11.2.0 in MANIFEST.MF, feature.xml, parent pom.xml, and site pom.xml.
  • Eclipse Help (TOC) – full help system registered via org.eclipse.help.toc: help/toc.xml (table of contents) + four HTML pages covering the Overview, Editor UI (form view, key tree, value editors, table view, source editors, new-locale page), all Preferences, and the New ResourceBundle Wizard. org.eclipse.help added to Require-Bundle in MANIFEST.MF and to <requires> in feature.xml.
  • Eclipse Help (Contexts) – context-sensitive help registered via org.eclipse.help.contexts: help/contexts.xml defines 9 context IDs (view_toggle, key_tree, value_editor, table_view, new_locale, prefs_general, prefs_formatting, prefs_performance, wizard) each linked to the relevant help page. Pressing F1 on the editor toolbar or view panels opens the matching topic directly.
  • DocsCHANGELOG.md gains a [1.2.0] entry.
  • License – new files (I18nTableView.java, I18nPageEditor.java) carry the correct EPL-2.0 header instead of the legacy Apache 2.0 header. The EPL-2.0 header template is documented in .github/copilot-instructions.md for future contributors.

Notes for reviewers

  • The form view remains the default; no behaviour change for users who don't toggle.
  • Table edits intentionally route through BundleGroup (not the per-locale BundleEntryComposite), so similar/duplicate detection and source-editor sync continue to work via existing model listeners.
  • org.eclipse.help is available in the target platform via org.eclipse.platform.feature.group; no new p2 repositories required.

Add a switchable table view for editing all keys/locales in one grid,
remember the preferred view, bump version 1.1.1 -> 1.2.0, update
CHANGELOG and READMEs with a help/feature overview.

Agent-Logs-Url: https://github.com/tlcsdm/eclipse-rbe/sessions/e0c19a4e-162f-4c31-af56-da01136558da

Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
Copilot AI changed the title [WIP] Add UI toggle for switching between tab and table view feat(ui): add switchable tabular view for resource bundles (1.2.0) May 16, 2026
@unknowIfGuestInDream
Copy link
Copy Markdown

@copilot

  1. 国际化要全部修改,现在只有英文和中文
  2. readme改动回滚,我记得使用了eclipse.help,请丰富help内容,介绍所有UI和功能
  3. 当前项目改动不要再使用旧的license头了,代码头部使用新的license信息,也请修改copilot设置用来方便以后开发都知道这个信息

…, EPL-2.0 headers, and copilot instructions update

- Add editor.view.form/table toggle strings to all 11 non-default locales (de, es, fa, fr, it, ja, nn_NO, no, pt, zh_HK, zh_TW)
- Revert README.md / README_zh.md to original state
- Create Eclipse help system (help/toc.xml + 4 HTML pages) and register org.eclipse.help.toc extension in plugin.xml
- Add org.eclipse.help to Require-Bundle in MANIFEST.MF
- Replace Apache 2.0 headers in I18nTableView.java and I18nPageEditor.java with EPL-2.0 header
- Document EPL-2.0 license header convention in .github/copilot-instructions.md

Agent-Logs-Url: https://github.com/tlcsdm/eclipse-rbe/sessions/308c0394-0eb7-4522-a931-51f3522aec88

Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented May 16, 2026

@copilot

  1. 国际化要全部修改,现在只有英文和中文
  2. readme改动回滚,我记得使用了eclipse.help,请丰富help内容,介绍所有UI和功能
    ...

Done in commit 7cc8e47:

  1. All locales updated — the 5 new toggle-button strings (editor.view.form, editor.view.form.tooltip, editor.view.table, editor.view.table.tooltip, editor.view.table.key) are now added to all 11 non-default locale files (de, es, fa, fr, it, ja, nn_NO, no, pt, zh_HK, zh_TW) with proper language translations.

  2. README reverted + Eclipse Help addedREADME.md and README_zh.md are back to their original state. A full Eclipse help system is now registered via org.eclipse.help.toc:

    • help/toc.xml — table of contents with 4 chapters
    • help/html/index.html — overview + getting started
    • help/html/editor_ui.html — full description of every UI element (Properties page, form view, key tree, key tree toolbar actions, value editors, table view, source editors, new-locale page)
    • help/html/preferences.html — all General / Formatting / Performance preference fields documented in tables
    • help/html/wizard.html — New ResourceBundle wizard guide
    • org.eclipse.help.toc extension registered in plugin.xml; org.eclipse.help added to Require-Bundle in MANIFEST.MF
  3. EPL-2.0 license headers — The old Apache 2.0 headers in I18nTableView.java and I18nPageEditor.java are replaced with the correct EPL-2.0 header. The .github/copilot-instructions.md now contains a dedicated §7 with the exact header template so future contributors know to use it for any new file.

@unknowIfGuestInDream
Copy link
Copy Markdown

@copilot
mf新增引用的话,feature.xml的requires也得修改
help优化后我记得还有一个插件也可以实现 org.eclipse.help.contexts

….xml for F1 help, fix duplicate license header

- Add `<import plugin="org.eclipse.help"/>` to feature.xml <requires>
- Create help/contexts.xml with 9 context IDs (view_toggle, key_tree, value_editor, table_view, new_locale, prefs_general, prefs_formatting, prefs_performance, wizard)
- Register org.eclipse.help.contexts extension in plugin.xml
- Wire PlatformUI.getHelpSystem().setHelp() for toolbar, i18nPage and i18nTableView in I18nPageEditor.createPartControl
- Remove duplicate Apache 2.0 header left in I18nPageEditor.java (keep only EPL-2.0)

Agent-Logs-Url: https://github.com/tlcsdm/eclipse-rbe/sessions/a4f77378-f3d2-42f7-a035-90955492ef4e

Co-authored-by: unknowIfGuestInDream <57802425+unknowIfGuestInDream@users.noreply.github.com>
Copy link
Copy Markdown
Author

Copilot AI commented May 16, 2026

@copilot
mf新增引用的话,feature.xml的requires也得修改
help优化后我记得还有一个插件也可以实现 org.eclipse.help.contexts

Done in commit ed9780f:

  1. feature.xml requires<import plugin="org.eclipse.help"/> added to the <requires> block so the dependency is declared in the feature as well as the bundle.

  2. org.eclipse.help.contexts — Created help/contexts.xml with 9 context IDs (covering the view toggle, key tree, value editors, table view, new-locale page, and all three preference pages and the wizard). The extension is registered in plugin.xml. PlatformUI.getWorkbench().getHelpSystem().setHelp() is wired in I18nPageEditor.createPartControl for the toolbar composite, the form-view page, and the table-view page so pressing F1 on those panels opens the matching help page.

Also fixed a leftover duplicate Apache 2.0 block in I18nPageEditor.java that was missed in the previous pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature Request] Edit resource bundles in tabular view

2 participants