fix(ci): use cmake --build . instead of make for luv - #61
Merged
Conversation
On Windows (MSYS2), CMake defaults to the Ninja generator. Running 'make' after 'cmake .' caused the build to use luv's original Makefile instead of the CMake-generated build system. The original Makefile ran its own cmake command, ignoring our CMAKE_C_FLAGS (including the GCC 14+ pointer fix). Fixes: - Use 'cmake --build .' to build luv using the generated build system - Handle copying luv.dll on Windows instead of failing on luv.so
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows build release job failure:
error: passing argument 3 of 'uv__convert_utf16_to_utf8' from incompatible pointer type [-Wincompatible-pointer-types].Root Cause
On Windows (MSYS2), CMake defaults to the Ninja generator. Running
makeaftercmake .caused the build to useluv's originalMakefileinstead of the CMake-generated build system. The originalMakefileran its owncmakecommand, ignoring ourCMAKE_C_FLAGS(including the GCC 14+ pointer fix).Changes
justfile: Usecmake --build .to buildluvusing the generated build system.justfile: Handle copyingluv.dllon Windows instead of failing onluv.so.Testing
This ensures the CMake-generated build system (Ninja on Windows) is used, which respects the
CMAKE_C_FLAGSwe passed.