fix(ci): add UCRT64 to GITHUB_PATH for Windows build - #55
Merged
Conversation
…igration - Pin all GitHub Actions to immutable SHA digests (SLSA Level 3) - Add Renovate configuration with corrected lux.toml regex and github-tags datasource (no native luarocks datasource exists) - Map busted, luacov, luastatic to their canonical GitHub repos - Add SBOM generation (anchore/sbom-action) for linux-x86_64 only - Add build provenance attestation (actions/attest-build-provenance) - Add update-release-notes job with attestation verification instructions - Add luarocks-publish environment to publish workflow - Fix indentation in publish.yml rockspec cleanup step - Preserve paths-ignore in release-please workflow - No permission changes to tests.yml (inherits repo default read)
…ensure-deps The Windows build failed with 'ToolNotFound: failed to find tool gcc' because: 1. The MSYS2 setup-msys2 action only adds C:\msys64\usr\bin to GITHUB_PATH, not the UCRT64 subsystem bin directory. Native Windows programs (lx.exe, just.exe) couldn't find gcc.exe or lua.exe on the PATH. 2. The justfile's ensure-deps recipe didn't pass --lua-dir like other lx invocations, causing Lux to fail discovering Lua on non-standard paths. Fixes: - Add 'Add UCRT64 to PATH (Windows)' step after MSYS2 setup - Pass --lua-dir to ensure-deps recipe in justfile
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the Windows build release job failure:
ToolNotFound: failed to find tool "gcc".Root Cause
Two interrelated issues:
MSYS2 PATH gap: The
msys2/setup-msys2action only addsC:\msys64\usr\binto$GITHUB_PATH, not the UCRT64 subsystem bin directory (C:\msys64\ucrt64\bin). Native Windows programs (lx.exe,just.exe) that run outside the MSYS2 translation layer cannot findgcc.exeorlua.exe.Missing
--lua-dirin justfile: Theensure-depsrecipe didn't pass--lua-dirlike every otherlxinvocation, causing Lux to fail auto-discovering Lua on non-standard paths (MSYS2 installs Lua at/ucrt64/bin/lua.exe).Changes
.github/workflows/release-please.yml: AddAdd UCRT64 to PATH (Windows)step after MSYS2 setup that addsC:\msys64\ucrt64\binto$GITHUB_PATHjustfile: Pass--lua-dir {{ lua_prefix }}to theensure-depsrecipe, consistent with all otherlxinvocationsTesting
This is a pre-existing issue — the Windows build has always had this PATH gap. The fix ensures
gcc.exe,lua.exe, and other UCRT64 tools are discoverable by native Windows programs.