feat: add Homebrew formula and expand CI platform matrix - #48
Merged
Conversation
Add Homebrew tap installation to README, expand the CI release matrix to build binaries for macOS Intel (x86_64 cross-compilation) and Linux ARM64 (native ubuntu-24.04-arm runner), and update the justfile to support cross-compilation via CMAKE_OSX_ARCHITECTURES and CC env vars. Changes: - Add linux-aarch64 and macos-x86_64 to release-please build matrix - Use dpkg-architecture for dynamic LUA_LIB path on Linux - Build Lua 5.4 from source for macOS Intel cross-compilation - Add lipo-based architecture verification for macOS builds - Split upload steps per platform; scope rockspec to linux-x86_64 - Add cmake_osx_arch_flag and cc variables to justfile - Reorder README installation: Homebrew > Binary (4 platforms) > Library - Remove stale docs/ entry from AGENTS.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tkolleh/homebrew-tap) with formula forrodav1.13.10 —brew install tkolleh/tap/rodaubuntu-24.04-arm) and macOS Intel (cross-compiled on ARM64 runner)CMAKE_OSX_ARCHITECTURES,CCvariables)Details
CI changes (
.github/workflows/release-please.yml)linux-aarch64onubuntu-24.04-arm,macos-x86_64onmacos-latestLUA_LIBpath viadpkg-architecture(fixes hardcoded x86_64 multiarch path)-arch x86_64through entire toolchainlipo -archsverification step for macOS buildslinux-x86_64onlyjustfile
cmake_osx_arch_flagpassesCMAKE_OSX_ARCHITECTUREStobuild-luvcmakeccvariable replaces hardcodedgccinbuild-systemHomebrew tap (separate repo)
tkolleh/homebrew-tapwithFormula/roda.rbTest plan
brew audit --new tkolleh/tap/rodapassesbrew style tkolleh/tap/rodapasses (no offenses)brew install tkolleh/tap/rodainstalls to/opt/homebrew/Cellar/roda/1.13.10brew test rodapassesroda --helpworks after installroda --title "..." --spinner dots2 -- sleep 2spins and exits 0/opt/homebrew/bin/roda, architectureMach-O 64-bit executable arm64just --fmt --checkpassesroda-linux-aarch64.tar.gzandroda-macos-x86_64.tar.gz(verified on first release)