Skip to content

fix(ci): consolidate LuaRocks publication to tag-triggered workflow #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tkolleh merged 1 commit into from
Apr 9, 2026
Merged

fix(ci): consolidate LuaRocks publication to tag-triggered workflow #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ jobs:
fi

echo "✓ Rockspec valid: $ROCKSPEC"
rm -f "$ROCKSPEC" # Clean up, lx upload will regenerate
rm -f "$ROCKSPEC" # Clean up, lx upload will regenerate

# Sole LuaRocks publication point - uses lx upload which has built-in JSON
# handling and doesn't require system Lua JSON libraries
- name: Upload to LuaRocks
run: lx --lua-version 5.1 upload
run: lx --lua-version 5.1 upload --verbose
env:
LUX_API_KEY: ${{ secrets.LUX_API_KEY }}
18 changes: 11 additions & 7 deletions .github/workflows/release-please.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ permissions:
jobs:
release:
name: Release
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- uses: googleapis/release-please-action@v4
id: release
Expand Down Expand Up @@ -74,9 +74,13 @@ jobs:
run: |
gh release upload ${{ steps.release.outputs.tag_name }} roda roda.sha256 *.rockspec

- name: Publish to LuaRocks
if: ${{ steps.release.outputs.release_created }}
env:
LUAROCKS_API_KEY: ${{ secrets.LUAROCKS_API_KEY }}
run: |
luarocks upload *.rockspec --api-key=${LUAROCKS_API_KEY}
# LuaRocks publication moved to publish.yml workflow (tag-triggered)
# to avoid dependency issues and simplify debugging. The publish.yml
# workflow uses lx upload which has built-in JSON handling and doesn't
# require system Lua JSON libraries like luarocks upload does.
# - name: Publish to LuaRocks
# if: ${{ steps.release.outputs.release_created }}
# env:
# LUAROCKS_API_KEY: ${{ secrets.LUAROCKS_API_KEY }}
# run: |
# luarocks upload *.rockspec --api-key=${LUAROCKS_API_KEY}
Loading