Conversation
Upgrade syntax to leverage:
- Native path joining (/)
- Built-in conditional checks like os() == 'macos'
- path_exists() for filesystem evaluation
- clean() and absolute_path() for resolving string paths
- Explicit [doc('...')] attributes for recipe documentation
- Rename unused err parameters to _err in roda/init.lua - Add .luacheckrc to suppress stylistic warnings - Add CI-specific just recipes (lint-ci, test-ci) for Lua 5.4 - Update GitHub workflow to use just and pass WITH_SHARED_LIBUV=OFF - Ensure --no-lock flag is used to avoid lockfile conflicts
- Replace apt install with curl download to get newer version supporting unstable setting - Ensure CI uses compatible just version with local development
- Rename Justfile to justfile (lowercase standard) - Use lua_prefix variable derived from brew --prefix on macOS, /usr elsewhere - Add lua_version variable (default 5.5) for include path construction - Replace lua55_dir references with lua_prefix and lua_include - Allow LUA_PREFIX and LUA_INCLUDE environment overrides for cross-platform compatibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary