Skip to content

fix(config): bound ConfigWatcher stop-path drain#90

Merged
tkhquang merged 1 commit into
mainfrom
fix/config-watcher-drain
May 29, 2026
Merged

fix(config): bound ConfigWatcher stop-path drain#90
tkhquang merged 1 commit into
mainfrom
fix/config-watcher-drain

Conversation

@tkhquang
Copy link
Copy Markdown
Owner

Summary

  • Bound the ConfigWatcher stop-path drain (timed wait, then directory-handle close to force IRP completion, then leak the heap-bundled I/O buffer) so a deleted watched directory cannot hang teardown.
  • Refresh the ConfigWatcher docs and reflow aob-signatures.md section 4.7 to the document's long-line convention (pure reformat, no content change).

Replace the unbounded GetOverlappedResult drain with a bounded, escalating wait (timed wait, then directory-handle close to force IRP completion, then leak the heap-bundled I/O buffer) so a deleted watched directory cannot hang teardown. Reflow aob-signatures.md 4.7 to the doc's long-line convention and refresh the ConfigWatcher docs.
@tkhquang tkhquang self-assigned this May 29, 2026
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 29, 2026

Warning

Review limit reached

@tkhquang, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 28 minutes and 44 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 27678dd8-031a-4e41-8f0c-4dca999fd077

📥 Commits

Reviewing files that changed from the base of the PR and between 6837d1d and 9973987.

📒 Files selected for processing (5)
  • AGENTS.md
  • docs/config-hot-reload/README.md
  • docs/misc/aob-signatures.md
  • src/config_watcher.cpp
  • tests/test_config_watcher.cpp

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tkhquang tkhquang merged commit a43818a into main May 29, 2026
2 checks passed
@tkhquang tkhquang deleted the fix/config-watcher-drain branch May 29, 2026 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant