feat: breaking rename external connectivity in config to enable egress to match api#156
Merged
Merged
Conversation
daniilrrr
approved these changes
Jun 3, 2026
| pub quorum_public_key: String, | ||
| #[serde(default)] | ||
| pub external_connectivity: Option<bool>, | ||
| pub enable_egress: Option<bool>, |
Contributor
There was a problem hiding this comment.
i think Option<bool> is redundant, should just be bool and the absence of a value when deserializing the JSON -> false not None. This is what I did in my earlier PR with dangerous_enable_debug_mode_deployments: bool below.
The question comes down to whether we there is a meaningful distinction between 3 values [None, Some(false), Some(true)] or 2 [false, true], and I think it's the latter case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename config field name to better align with api field name