Bump rubocop-rbs_inline to 1.6.0 and drop RbsInline Excludes#183
Merged
Conversation
tk0miya
force-pushed
the
chore/bump-rubocop-rbs_inline
branch
from
b84f577 to
dbf5326
Compare
rubocop-rbs_inline 1.6.0 no longer reports the spec files that the Style/RbsInline cops used to flag, so the spec Excludes are no longer necessary. 1.6.0 does, however, now check class instance variables, so the Configuration module needs explicit annotations. - Gemfile.lock: rubocop-rbs_inline 1.5.5 -> 1.6.0 - .rubocop.yml: remove the spec Excludes from Style/RbsInline/MissingTypeAnnotation and RedundantTypeAnnotation, and drop the Style/RbsInline/UntypedInstanceVariable override - configuration.rb: annotate the class instance variables with `# @RBS self.@...` (Style/RbsInline/UntypedInstanceVariable) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
tk0miya
force-pushed
the
chore/bump-rubocop-rbs_inline
branch
from
dbf5326 to
d513b45
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rubocop-rbs_inline1.6.0 no longer reports the spec files that theStyle/RbsInlinecops used to flag, so thespec/**/*Excludes are nolonger necessary.
Changes
Gemfile.lock:rubocop-rbs_inline1.5.5 → 1.6.0.rubocop.yml: remove thespec/**/*Excludes fromStyle/RbsInline/MissingTypeAnnotationandStyle/RbsInline/RedundantTypeAnnotation, and drop theStyle/RbsInline/UntypedInstanceVariableoverrideThe
cooldown: 7source option is unchanged (it was only relaxedtemporarily to pull the freshly released 1.6.0 into the lockfile).
🤖 Generated with Claude Code