feat(web): add light/dark theme toggle button to rendered page#4
Merged
Conversation
Add a light/dark theme toggle button in the page header that allows switching themes independently of the editor's g:mkdp_theme setting. The user's choice is persisted in localStorage and takes priority over incoming editor theme data until the page is reloaded without a saved preference. Changes: - Add toggle button element to index.html header - Add explicit [data-theme] CSS custom property blocks for both light and dark themes, including full github-markdown.css variable overrides - Add toggle click handler with localStorage persistence and a _userThemeOverride flag to prevent editor theme data from clobbering the user's manual choice - Move data-theme attribute from <main> to <html> for broader scope Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: TJ Hoplock <t.hoplock@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a light/dark theme toggle button in the page header that allows
switching themes independently of the editor's g:mkdp_theme setting. The
user's choice is persisted in localStorage and takes priority over
incoming editor theme data until the page is reloaded without a saved
preference.
Changes:
and dark themes, including full github-markdown.css variable overrides
_userThemeOverride flag to prevent editor theme data from clobbering
the user's manual choice
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Signed-off-by: TJ Hoplock t.hoplock@gmail.com