Skip to content

Fix how kwargs are handled with a request #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trevorflahardy wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix how kwargs are handled with a request #3

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0d1d902
Forgot two **
trevorflahardy Jul 19, 2021
603b5c7
Update how kwargs are handled with url params
trevorflahardy Jul 19, 2021
9391cea
Merge branch 'tixte:main' into main
trevorflahardy Jul 19, 2021
0265324
Remove comments, api returns json
trevorflahardy Jul 19, 2021
ce3d8ea
Merge branch 'main' of https://github.com/NextChai/tixte.py
trevorflahardy Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tixte/http.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,9 @@ def __init__(self, session: Optional[aiohttp.ClientSession] = None) -> None:


async def request(self, route: Route, **kwargs: Any) -> Dict:
async with self.session.request(route.method, route.url, {**route.parameters, **kwargs}) as resp:
kwargs = {**route.parameters, **kwargs}
async with self.session.request(route.method, route.url, **kwargs) as resp:
if resp.status != 200:
raise NotImplementedError("API status was not 200, this hasn't been implemented yet.")

# We're going to assume the API returns Dict for now.
# We'll change this later as I get more info.
return await resp.json()


return await resp.json()