-
Notifications
You must be signed in to change notification settings - Fork 33
Workflow fixes, documentation reorganization, and LibTorch integration #560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
bHimes
merged 24 commits into
timothygrant80:master
from
StochasticAnalytics:workflow_fix_and_tooling_updates
Oct 2, 2025
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
cb5178a
Pulled in just the necessary changes to compile and use Johannes mods…
bHimes ea30cc0
roll back changes for the unblurring of decolace to the main branch f…
bHimes e5a0374
Update build system to be more robust
bHimes a761a86
Hot fix to patch workflow not getting state info on workflow switch. …
bHimes 977020b
finally a solution to the workflow issue
bHimes 1a910cb
Clean up workflow switching debug code and add comprehensive document…
bHimes 8149bc0
Fix workflow switching crash in MatchTemplatePanel::FillGroupComboBox()
bHimes fcc4db9
Add wxWidgets Modern C++ Best Practices to CLAUDE.md
bHimes e3ec576
Reorganize CLAUDE.md documentation into hierarchical structure
bHimes 5bc5f8c
fixed workflow details, TM results to results panel.
bHimes 8a5af94
wip
bHimes 50d378d
wip: claude can add a button.
bHimes 128c36e
Add opt-in LibTorch support for ML-based tools
bHimes 6559726
Add worktrees/ to .gitignore to support git worktree workflow
bHimes f6118f6
Add clang-format-14 enforcement with pre-commit hook and CI workflow
bHimes f57291c
Fixes files caught during CI due to changes in the last commit (that …
bHimes c75353d
Add concurrency groups to CI workflows to auto-cancel redundant runs
bHimes 40545b8
Make build workflows depend on formatting check success
bHimes a993b3f
Fix clang-format violations found by CI
bHimes 29958b1
Add pull_request triggers to build workflows
bHimes 161a6a3
Fix build workflow conditional to support pull_request events
bHimes ec4ad0b
Refactor CI workflows to use check_formatting as orchestrator
bHimes 7db42b3
Fix concurrency group deadlock in reusable workflows
bHimes de17fea
Fix pre-commit hook to use full paths in generated fix script
bHimes File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "permissions": { | ||
| "allow": [ | ||
| "Bash(find:*)", | ||
| "Bash(git branch:*)", | ||
| "Bash(git show-branch:*)", | ||
| "Bash(git merge-base:*)", | ||
| "Bash(git ls-tree:*)", | ||
| "Bash(grep:*)" | ||
| ], | ||
| "deny": [], | ||
| "ask": [] | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,52 @@ | ||
| name: Check C++ Formatting | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| - '*_with_ci' | ||
| pull_request: | ||
| branches: master | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| jobs: | ||
| check-format: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - name: Checkout code | ||
| uses: actions/checkout@v3 | ||
|
|
||
| - name: Check C++ formatting | ||
| uses: RafikFarhad/clang-format-github-action@v3 | ||
| with: | ||
| sources: "src/**/*.cpp,src/**/*.h,src/**/*.cc,src/**/*.cxx,src/**/*.hpp,src/**/*.cu,src/**/*.cuh" | ||
| excludes: "include/**/*,src/gui/wxformbuilder/**/*,src/gui/*ProjectX_gui*" | ||
| style: file | ||
|
|
||
| # Build workflows - only run if formatting check passes | ||
| build-gpu-debug: | ||
| needs: check-format | ||
| uses: ./.github/workflows/debug_build.yml | ||
|
|
||
| build-cpu-debug: | ||
| needs: check-format | ||
| uses: ./.github/workflows/debug_build_cpu_only.yml | ||
|
|
||
| build-gpu-release: | ||
| needs: check-format | ||
| uses: ./.github/workflows/release_build.yml | ||
|
|
||
| build-gpu-release-gnu-mkl: | ||
| needs: check-format | ||
| uses: ./.github/workflows/release_build_GNU_mkl.yml | ||
|
|
||
| build-gpu-release-clang-mkl: | ||
| needs: check-format | ||
| uses: ./.github/workflows/release_build_clang_mkl.yml | ||
|
|
||
| build-gpu-release-no-experimental: | ||
| needs: check-format | ||
| uses: ./.github/workflows/release_build_full_no_experimental.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
|
|
||
| { | ||
| "folders": [ | ||
| { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.1.3 | ||
| 2.2.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 2.2.1 | ||
| 2.2.2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am assuming that this only prevents having to individually approve a series of actions, rather than default approving all changes made by the agent?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This approves specific tools, and specifically blocks others. So non-destructive actions like grep are good to approve so you don't have to babysit as much. These rules are for github copilot chat specifically, so they can probably be deprecated. I doubt I'll be switching back. Happy to wait to see what you think of claude code first.