feat: add sklearn CV compatibility to SimilarityStratifiedSplit - #17
Merged
Conversation
timothyckl
commented
Mar 4, 2026
timothyckl
commented
Owner
- get_n_splits and split now accept X, y, groups kwargs to match the sklearn BaseCrossValidator interface, enabling use with cross_val_score, GridSearchCV, etc.
- split raises ValueError with a descriptive message when y is None
- add scikit-learn to dev extras so the integration test runs in CI
- document sklearn compatibility in README and class docstring
- get_n_splits and split now accept X, y, groups kwargs to match the sklearn BaseCrossValidator interface, enabling use with cross_val_score, GridSearchCV, etc. - split raises ValueError with a descriptive message when y is None - add scikit-learn to dev extras so the integration test runs in CI - document sklearn compatibility in README and class docstring
timothyckl
force-pushed
the
feat/sklearn-compat
branch
from
March 4, 2026 08:15
12e000d to
1043afb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.