Fix VacationHold.enabled reading the wrong JSON key#170
Open
clutch2sft wants to merge 1 commit into
Open
Conversation
Resideo's device response returns vacationHold.Enabled (capital E),
not vacationHold.enabled. Confirmed against a live captured payload
from a T9-T10 account: {'vacationHold': {'Enabled': False}}.
Because the property silently defaulted to False on the missing key,
an active vacation hold would always report as off with no error -
same failure mode as the other field-name mismatches already fixed
in this library.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because the property silently defaulted to
Falseon the missing key, an activevacation hold would always report as off — no error, no exception, just wrong data.
Same failure mode as the other field-name mismatches already fixed in this library
(
#165).Changes
aiolyric/objects/device.py:VacationHold.enablednow readsEnabled.tests/__init__.py,tests/objects/test_device.py,tests/objects/test_location.py:fixtures and assertions updated to match.
pytest tests/objects/passes (3/3).Context
Found via a Copilot review comment on a companion
home-assistant/corePR(
Ocala Thermostatroom-sensor work), then confirmed against a debug log alreadycaptured from a live account rather than guessed.