Remove stale Vulkan compile gates and legacy OpenGL cvar plumbing#266
Draft
cursor[bot] wants to merge 3 commits into
Draft
Remove stale Vulkan compile gates and legacy OpenGL cvar plumbing#266cursor[bot] wants to merge 3 commits into
cursor[bot] wants to merge 3 commits into
Conversation
- Unwrap USE_VBO_GRID (always enabled with USE_VBO) in Vulkan renderer - Remove dead USE_TESS_NEEDS_NORMAL/ST2 conditional branches (never defined) - Gate r_allowSoftwareGL/r_glDriver behind USE_OPENGL_API (Vulkan-only builds) Co-authored-by: Tim Fox <timfox@outlook.com>
These shader metadata fields were only consumed by the removed USE_TESS_NEEDS_NORMAL/ST2 tess gating path. Tessellation now always gathers normals and lightmap ST2 coordinates. Co-authored-by: Tim Fox <timfox@outlook.com>
USE_VK_PBR is unconditionally defined in tr_local.h; drop the #else branch that loaded legacy non-PBR vertex/fragment modules. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags removed
tr_local.h). Grid VBO path is the only path.#ifdefbranches were dead; tessellation always gathers normals and lightmap ST2.vk_shader_modules.c#defined; non-PBR shader module init was unreachable.Behavioral parity
vk_bind_generated_shaders()unchanged.Validation
./scripts/compile_engine.sh vulkan— successtests/scripts/test_vulkan_regression_source_guards.sh— PASS./scripts/smoke_test.sh— PASSNot removed (low confidence)
Runtime toggles still in use:
r_forwardPlus,r_renderMode,r_vbo,r_pbr,r_volumetricFog, RTX cvars. Broader USE_VK_PBR / USE_VBO#ifdefunwrapping in headers deferred.