Remove stale Vulkan compile-time flags and legacy OpenGL cvar plumbing#264
Draft
cursor[bot] wants to merge 2 commits into
Draft
Remove stale Vulkan compile-time flags and legacy OpenGL cvar plumbing#264cursor[bot] wants to merge 2 commits into
cursor[bot] wants to merge 2 commits into
Conversation
- Unwrap USE_VBO_GRID (always enabled with USE_VBO) in Vulkan renderer - Remove dead USE_TESS_NEEDS_NORMAL/ST2 conditional branches (never defined) - Gate r_allowSoftwareGL/r_glDriver behind USE_OPENGL_API (Vulkan-only builds) Co-authored-by: Tim Fox <timfox@outlook.com>
These shader metadata fields were only consumed by the removed USE_TESS_NEEDS_NORMAL/ST2 tess gating path. Tessellation now always gathers normals and lightmap ST2 coordinates. Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags removed
USE_VBO_GRIDUSE_VBOis on (tr_local.h); grid surfaces always use the VBO path in production builds. Unwrapped#ifdefguards invk_vbo.candtr_surface.c.USE_TESS_NEEDS_NORMAL/USE_TESS_NEEDS_ST2tr_local.h). Active path already always gathers normals and lightmap ST2; conditional branches were dead.shader.needsNormal/shader.needsST2+DetectNeeds()r_allowSoftwareGL/r_glDriverUSE_OPENGL_APIso MSVC/OpenGL platform builds retain them; duplicate SDL registration removed.Behavioral parity checks
./scripts/compile_engine.sh vulkan— clean Release buildctest -R test_vulkan_regression_source_guards— passed./scripts/smoke_test.sh— passed (includesq3_openarena_compat_check.sh)Scope notes
Runtime toggles with real off-paths (
r_forwardPlus,r_vbo,r_renderMode, RTX cvars, etc.) were intentionally left unchanged.