Remove stale compile-time feature flags and legacy OpenGL cvar plumbing#260
Draft
cursor[bot] wants to merge 1 commit into
Draft
Remove stale compile-time feature flags and legacy OpenGL cvar plumbing#260cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Unwrap USE_VBO_GRID (always enabled with USE_VBO) in Vulkan renderer - Remove dead USE_TESS_NEEDS_NORMAL/ST2 conditional branches (never defined) - Gate r_allowSoftwareGL/r_glDriver behind USE_OPENGL_API (Vulkan-only builds) Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags removed
USE_VBO_GRIDUSE_VBOis on (tr_local.h); no off-path in Vulkan buildsUSE_TESS_NEEDS_NORMAL/USE_TESS_NEEDS_ST2r_allowSoftwareGL/r_glDriverregistrationUSE_VULKAN_APIwithoutUSE_OPENGL_API. Cvars now only register whenUSE_OPENGL_APIis defined; SDL GL attribute block wrapped likewiseBehavioral parity
#ifdefwrappers removedUSE_TESS_NEEDS_*was undefined)Checks performed
./scripts/compile_engine.sh vulkan— clean buildctest -R test_vulkan_regression_source_guards— passed./scripts/smoke_test.sh— passed (includesq3_openarena_compat_check.sh)Not in scope (low confidence)
Runtime cvars with real off-paths (
r_renderMode,r_forwardPlus,r_vbo,r_pbr, RTX toggles) left unchanged.