Feature-flag cleanup: remove stale USE_BANS, USE_TESS_NEEDS_*, USE_STB_TRUETYPE#259
Draft
cursor[bot] wants to merge 1 commit into
Draft
Feature-flag cleanup: remove stale USE_BANS, USE_TESS_NEEDS_*, USE_STB_TRUETYPE#259cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Drop ghost USE_STB_TRUETYPE from compile_engine.sh and CI (never read by CMake) - Remove never-compiled USE_BANS server ban system and auth-server hooks - Flatten dead USE_TESS_NEEDS_* renderer gates (defines were already commented out) - Simplify VDB init to NanoVDB-only messaging (USE_OPENVDB never defined) - Remove deprecated cg_stereoSeparation ROM cvar registration Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes stale feature flags and dead gated branches that were already inactive or never wired into the build. No intentional behavior change on the active code paths.
Flags removed
USE_STB_TRUETYPEcompile_engine.shand CI but never referenced inCMakeLists.txt— pure ghost CMake flag.USE_BANSbanUser/banClienthooks were inside the same never-compiled block.USE_TESS_NEEDS_NORMAL/USE_TESS_NEEDS_ST2tr_local.hwere already commented out, so all conditional branches were inactive. Tessellation already followed the always-on copy path (normals + ST2).USE_OPENVDBcg_stereoSeparationBehavioral parity checks
./scripts/compile_engine.sh vulkan— Release build succeeded (GCC/Clang path via default script)./scripts/smoke_test.sh— 17/17 passed (binary checks, server startup, shader validation, compatibility guards)Follow-up candidates (not in this PR — lower confidence or larger scope)
USE_VK_PBR/USE_VBO/USE_FOG_COLLAPSEdefines intr_local.h(~30 renderer files)USE_VULKAN=OFFCMake option (already fatal-errors)0branches (r_forwardPlus,r_fbo, etc.) perdocs/DEPRECATION_POLICY.md