Remove stale Vulkan compile flags and legacy OpenGL cvar wiring#257
Draft
cursor[bot] wants to merge 1 commit into
Draft
Remove stale Vulkan compile flags and legacy OpenGL cvar wiring#257cursor[bot] wants to merge 1 commit into
cursor[bot] wants to merge 1 commit into
Conversation
- Drop dead non-PBR shader module fallback (USE_VK_PBR always on) - Inline USE_VBO_GRID path (always enabled with USE_VBO) - Remove disabled USE_TESS_NEEDS_* conditional wrappers - Register r_allowSoftwareGL/r_glDriver only when USE_OPENGL_API - Add regression guards for removed flag plumbing Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flags removed
USE_VK_PBR#elsebranch invk_shader_modules.cUSE_VK_PBRis unconditionally#defined intr_local.h; non-PBR shader module path was dead codectest -R smoke_testUSE_VBO_GRIDcompile gateUSE_VBOis on (also unconditional); grid VBO path is the only active pathUSE_TESS_NEEDS_NORMAL/USE_TESS_NEEDS_ST2r_allowSoftwareGL/r_glDriverregistration on Vulkan-only buildsUSE_VULKAN_APIonly (noUSE_OPENGL_API); cvars were documented as ignored legacy stubstest_vulkan_regression_source_guards.sh+ Q3/OA compat checkChanges
USE_VBO_GRIDifdef wrappers).USE_OPENGL_API; gate SDL GLimp usage similarly.tests/scripts/test_vulkan_regression_source_guards.sh.Candidates not removed (low confidence)
r_forwardPlus,r_vbo,r_pbr,r_renderMode,r_volumetricFog, RTX cvarsUSE_VBO/USE_VK_PBRouter#ifdefwrappers (large refactor)SKIP_IDPAK_CHECK(still used infiles.cand build scripts)Validation
./scripts/compile_engine.sh vulkan(Release) — passctest -R "smoke_test|test_vulkan_regression_source_guards"— pass./scripts/q3_openarena_compat_check.sh release— pass