test: cover client demo regression invariants#251
Draft
cursor[bot] wants to merge 1 commit into
Draft
Conversation
Co-authored-by: Tim Fox <timfox@outlook.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Risky behavior now covered
CL_ParseServerMessage, pure-server bypass/restore ordering, protocol fallback, and playback state setup before priming.cl_main.cdelegation tocl_demo.cplus demo command add/remove lifecycle.Test files added/updated
tests/scripts/test_client_demo_regressions.sh.CMakeLists.txtwithtest_client_demo_regressions.tests/README.mdvalidation list.Why this reduces regression risk
The recent demo-module extraction moved core record/playback behavior into a new file without a runtime-friendly test path in headless CI. These guards cover parser bounds checks, file probing, and command lifecycle invariants that can break demo playback/recording or allow malformed demo data to reach the parser.
Validation
tests/scripts/test_client_demo_regressions.shcmake -S . -B build-coverage-tests -DBUILD_TESTING=ON -DBUILD_UNIT_TESTS=OFF && ctest --test-dir build-coverage-tests -R test_client_demo_regressions --output-on-failure