tests: cover renderer regression map runner

CMakeLists.txt

@@ -2469,6 +2469,13 @@ set_tests_properties(test_demo_game_pk3 PROPERTIES
 	LABELS "scripts;validation;examples"
 	REQUIRED_FILES "${CMAKE_SOURCE_DIR}/tests/scripts/test_demo_game_pk3.sh")
 
+add_test(NAME test_renderer_regression_maps
+	COMMAND ${CMAKE_SOURCE_DIR}/tests/scripts/test_renderer_regression_maps.sh ${CMAKE_SOURCE_DIR}/scripts/renderer_regression_maps.sh
+	WORKING_DIRECTORY ${CMAKE_SOURCE_DIR})
+set_tests_properties(test_renderer_regression_maps PROPERTIES
+	LABELS "unit;scripts;validation;renderer"
+	REQUIRED_FILES "${CMAKE_SOURCE_DIR}/tests/scripts/test_renderer_regression_maps.sh")
+
 add_test(NAME test_compile_engine_lto
 	COMMAND ${CMAKE_SOURCE_DIR}/tests/scripts/test_compile_engine_lto.sh ${CMAKE_SOURCE_DIR}/scripts/compile_engine.sh
 	WORKING_DIRECTORY ${CMAKE_SOURCE_DIR})

tests/README.md

@@ -2,4 +2,4 @@
 
 - **Unit** (`BUILD_UNIT_TESTS=ON`): `unit_macros`, `unit_qmath`, `unit_surfaceflags`, `unit_qhelpers`, `unit_crc`, `unit_pathutil`, `unit_msg`, `unit_info`, `unit_cm_bounds`, `unit_parse`, `unit_endian` (CRC, COM path, `Info_*`, `COM_Parse*`, and endian tests use the same minimal `stub_qcommon_min.c` + `q_shared.c` + `q_math.c` link as `unit_qhelpers`; `unit_msg` links `msg.c` + `huffman_static.c` with `stub_qcommon_min.c`, `stub_msg_cvar.c`, and `-DDEDICATED`; `unit_cm_bounds` links `cm_bounds.c` + `q_math.c` only) — run `ctest -R unit_` or `./unit_*` from the build directory.
 - **Script regression tests**: `test_botlib_bounded_strings` (botlib string invariants). Run with `ctest -R test_botlib_bounded_strings` from the build directory.
-- **Validation**: `smoke_test`, `renderer_regression_check`, `check_artifacts`, `test_run_vulkan_script`, `test_compile_engine_lto`, `test_demo_game_pk3`, `test_vk_vegetation_dispatch_order`, `test_vulkan_mesh_shader_opt_in`, `test_vulkan_runtime_regressions`, `test_botlib_chat_message_bounds`, `test_vulkan_renderer_guards`, `test_vulkan_regression_source_guards`, `test_gltf_opengl_regressions`, `test_botlib_bounded_strings` — see `scripts/`, `tests/scripts/`, and `docs/RENDERER_CONFIDENCE.md`.
+- **Validation**: `smoke_test`, `renderer_regression_check`, `check_artifacts`, `test_run_vulkan_script`, `test_compile_engine_lto`, `test_demo_game_pk3`, `test_renderer_regression_maps`, `test_vk_vegetation_dispatch_order`, `test_vulkan_mesh_shader_opt_in`, `test_vulkan_runtime_regressions`, `test_botlib_chat_message_bounds`, `test_vulkan_renderer_guards`, `test_vulkan_regression_source_guards`, `test_gltf_opengl_regressions`, `test_botlib_bounded_strings` — see `scripts/`, `tests/scripts/`, and `docs/RENDERER_CONFIDENCE.md`.

tests/scripts/test_renderer_regression_maps.sh

@@ -0,0 +1,138 @@
+#!/usr/bin/env bash
+# Deterministic coverage for renderer_regression_maps.sh without requiring game data.
+set -euo pipefail
+
+fail() {
+	echo "FAIL: $*" >&2
+	exit 1
+}
+
+assert_contains() {
+	local haystack="$1"
+	local needle="$2"
+	if [[ "$haystack" != *"$needle"* ]]; then
+		fail "missing expected text: $needle"
+	fi
+}
+
+assert_file_contains() {
+	local file="$1"
+	local needle="$2"
+	if ! grep -Fq -- "$needle" "$file"; then
+		echo "--- $file ---" >&2
+		sed -n '1,120p' "$file" >&2
+		fail "missing expected text in $file: $needle"
+	fi
+}
+
+assert_exit_code() {
+	local expected="$1"
+	local actual="$2"
+	if [[ "$actual" -ne "$expected" ]]; then
+		fail "expected exit code $expected, got $actual"
+	fi
+}
+
+if [[ $# -gt 1 ]]; then
+	fail "usage: $0 [path/to/renderer_regression_maps.sh]"
+fi
+
+SCRIPT_UNDER_TEST="${1:-}"
+if [[ -z "$SCRIPT_UNDER_TEST" ]]; then
+	SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+	SCRIPT_UNDER_TEST="$(cd "$SCRIPT_DIR/../.." && pwd)/scripts/renderer_regression_maps.sh"
+fi
+
+[[ -f "$SCRIPT_UNDER_TEST" ]] || fail "script under test not found: $SCRIPT_UNDER_TEST"
+
+FIXTURE="$(mktemp -d)"
+cleanup() { rm -rf "$FIXTURE"; }
+trap cleanup EXIT
+
+mkdir -p "$FIXTURE/scripts" "$FIXTURE/release" "$FIXTURE/game_root/base"
+touch "$FIXTURE/CMakeLists.txt"
+cp "$SCRIPT_UNDER_TEST" "$FIXTURE/scripts/renderer_regression_maps.sh"
+chmod +x "$FIXTURE/scripts/renderer_regression_maps.sh"
+
+SERVER_LOG="$FIXTURE/server_args.log"
+cat > "$FIXTURE/release/idtech3_server" <<'STUB'
+#!/usr/bin/env bash
+set -euo pipefail
+
+log="${STUB_SERVER_LOG:?}"
+{
+	printf 'CALL'
+	for arg in "$@"; do
+		printf '\t%s' "$arg"
+	done
+	printf '\n'
+} >> "$log"
+
+map=""
+previous=""
+for arg in "$@"; do
+	if [[ "$previous" == "+map" ]]; then
+		map="$arg"
+		break
+	fi
+	previous="$arg"
+done
+
+if [[ "${STUB_SERVER_MODE:-pass}" == "error-on-pbr" && "$map" == "rtest_pbr" ]]; then
+	echo "ERROR: simulated renderer map load failure for $map"
+	exit 0
+fi
+
+echo "Server: $map"
+STUB
+chmod +x "$FIXTURE/release/idtech3_server"
+
+out="$FIXTURE/pass.out"
+GAME_BASE="$FIXTURE/game_root/base" \
+	RELEASE_DIR="$FIXTURE/release" \
+	STUB_SERVER_LOG="$SERVER_LOG" \
+	"$FIXTURE/scripts/renderer_regression_maps.sh" > "$out" 2>&1
+
+pass_output="$(<"$out")"
+assert_contains "$pass_output" "fs_basepath -> $FIXTURE/game_root (game dir: base)"
+assert_contains "$pass_output" "=== Summary === Passed: 6  Failed: 0"
+assert_contains "$pass_output" "MAP LOAD SANITY PASSED"
+
+call_count="$(grep -c '^CALL' "$SERVER_LOG")"
+[[ "$call_count" -eq 6 ]] || fail "expected six map server calls, got $call_count"
+
+for map in rtest_tangent rtest_pbr rtest_emissive rtest_volumetric rtest_postfx rtest_parity; do
+	assert_file_contains "$SERVER_LOG" $'+set\tdedicated\t1'
+	assert_file_contains "$SERVER_LOG" $'+set\tfs_basepath\t'"$FIXTURE/game_root"
+	assert_file_contains "$SERVER_LOG" $'+set\tfs_game\tbase'
+	assert_file_contains "$SERVER_LOG" $'+set\tvm_game\t2'
+	assert_file_contains "$SERVER_LOG" $'+set\tbot_enable\t0'
+	assert_file_contains "$SERVER_LOG" $'+set\tcom_hunkMegs\t128'
+	assert_file_contains "$SERVER_LOG" $'+map\t'"$map"
+done
+
+error_out="$FIXTURE/error.out"
+set +e
+GAME_BASE="$FIXTURE/game_root/base" \
+	RELEASE_DIR="$FIXTURE/release" \
+	STUB_SERVER_LOG="$SERVER_LOG" \
+	STUB_SERVER_MODE=error-on-pbr \
+	"$FIXTURE/scripts/renderer_regression_maps.sh" > "$error_out" 2>&1
+status=$?
+set -e
+assert_exit_code 1 "$status"
+error_output="$(<"$error_out")"
+assert_contains "$error_output" "simulated renderer map load failure for rtest_pbr"
+assert_contains "$error_output" "map rtest_pbr: error in server log"
+assert_contains "$error_output" "MAP LOAD SANITY FAILED"
+
+missing_base_out="$FIXTURE/missing-base.out"
+set +e
+RELEASE_DIR="$FIXTURE/release" \
+	"$FIXTURE/scripts/renderer_regression_maps.sh" > "$missing_base_out" 2>&1
+status=$?
+set -e
+assert_exit_code 2 "$status"
+assert_contains "$(<"$missing_base_out")" "GAME_BASE = game **base** directory"
+
+echo "OK: renderer_regression_maps.sh argument mapping and failure detection"