Add per-party auto-join toggle (AllowAutoJoin) with UI checkbox#869
Draft
absol89 wants to merge 1 commit into
Draft
Add per-party auto-join toggle (AllowAutoJoin) with UI checkbox#869absol89 wants to merge 1 commit into
absol89 wants to merge 1 commit into
Conversation
Problem: The server-wide bAutoPartyJoin setting cannot be overridden
per-party. When enabled, all new players auto-join the sole party on
the server. Party leaders cannot opt out without disabling the setting
globally.
Solution: Add a per-party AllowAutoJoin flag (default true, matching
bAutoPartyJoin). The party leader can toggle it at runtime via an
'Auto Join' checkbox in the Party Menu UI. When disabled, the party
is excluded from auto-join for newly connecting players.
Changes:
- Protocol: New PartyAutoJoinToggleRequest message + opcode.
NotifyPartyInfo extended with AllowAutoJoin, ServerAutoJoin, PartyCount.
- Server: Party struct gains AllowAutoJoin{true}. OnPartyCreate sets
AllowAutoJoin = bAutoPartyJoin. OnPartyAutoJoinToggle handler lets
the leader flip it. OnPlayerJoin skips auto-join if AllowAutoJoin is
false. OnRemovePlayerFromParty broadcasts remaining party info when
a party is destroyed and only 1 remains.
- C++ client: Tracks AllowAutoJoin, ServerAutoJoin, PartyCount from
NotifyPartyInfo, forwards all to JS overlay.
- Angular UI: PartyInfo and Group models carry allowAutoJoin,
serverAutoJoin, partyCount. Party Menu shows an 'Auto Join'
checkbox (leader-only) that is:
* Checked when AllowAutoJoin is true
* Disabled when ServerAutoJoin is false OR PartyCount > 1
Translated in all 13 supported languages.
Contributor
Author
|
Comments about the full lifecycle: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: The server-wide bAutoPartyJoin setting cannot be overridden per-party. When enabled, all new players auto-join the sole party on the server. Party leaders cannot opt out without disabling the setting globally. This lets trolls repeatedly grief party cells on public servers, such as joining with enchantment mods and teleporting to players who crash, or killing their owned NPCs.
Solution: Add a per-party AllowAutoJoin flag (default true, matching bAutoPartyJoin). The party leader can toggle it at runtime via an 'Auto Join' checkbox in the Party Menu UI. When disabled, the party is excluded from auto-join for newly connecting players.
Changes: