Skip to content

Make it default to skip first byte in USS digest unless Castor detected#26

Merged
mchack-work merged 1 commit into
mainfrom
unlocked-uss
Mar 23, 2026
Merged

Make it default to skip first byte in USS digest unless Castor detected#26
mchack-work merged 1 commit into
mainfrom
unlocked-uss

Conversation

@mchack-work

@mchack-work mchack-work commented Mar 20, 2026

Copy link
Copy Markdown
Member

Description

  • Make it default to skip first byte in USS digest unless Castor detected.

  • To be backwards compatible with people using Unlocked as Bellatrix, skip first byte of USS digest when Unlocked is detected.

  • Update release notes for this bug fix.

  • Release note nit: Move Complete changelog item for v1.3.0 to be last in the note.

Type of change

  • Bugfix (non breaking change which resolve an issue)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes

@mchack-work mchack-work requested a review from dehanj March 20, 2026 13:09
- If Castor is detected or the WithFullUss() option function is active,
  send 32 byte digest.

- To be backwards compatible with people using Unlocked (PID 8) as
  Bellatrix we skip first byte of USS digest.

- Update release notes for this bug fix.

- Release note nit: Move Complete changelog item for v1.3.0 to be last
  in the note.
@mchack-work mchack-work merged commit 9df06e1 into main Mar 23, 2026
3 checks passed
@mchack-work mchack-work deleted the unlocked-uss branch March 23, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants