raft:Fix one log append reject bug about MsgUnreachable msg#475
Open
tier-cap wants to merge 2 commits into
Open
raft:Fix one log append reject bug about MsgUnreachable msg#475tier-cap wants to merge 2 commits into
tier-cap wants to merge 2 commits into
Conversation
Signed-off-by: tier-cap <zhengxiaojin@pingcap.com>
close tikv/tikv#11371 Signed-off-by: tier-cap <zhengxiaojin@pingcap.com> Signed-off-by: tier-cap <zhengxiaojin@pingcap.com>
1f58409 to
3dc6ec5
Compare
Member
|
I don't think it's a good idea. Internal messages mean we are subject to change without breaking any compatibility. You should define a new message on the TiKV side. |
Author
I have two fix, one is this pr, the other is add a new msg type. but the change is more tthan this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem Description:
close tikv/tikv#11371
Solution: