GML-2019 handle more table view display content types#22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Bug fix
Description
Standardize context key to
resultAdd empty-result check for queries
Expand table to new data formats
Improve routing prompt and UX toggles
Diagram Walkthrough
flowchart LR AG["generate_cypher: execute query"] --> IR["is_query_result_empty()"] IR -- "empty" --> ERR["state.context = {error: True, result: json_str}"] IR -- "not empty" --> CTX["state.context = {result, cypher, reasoning}"] CTX --> GA["generate_answer uses context.result"] ERR --> GA GA --> UICM["CustomChatMessage: Show Table requires result"] GA --> INTER["Interact: disable Graph/Table without data"] CTX --> KT["KnowledgeTablePro: render"] KT --> FT["SupportAI final_retrieval to chunk/text"] KT --> STR["String content as single-column table"] KT --> CKV["Cypher object values to Key/Value table"] PR["Route prompt tuned for history routing"] --> AGFile Walkthrough
base_llm.py
Tune routing prompt for history vs functions/vectorstorecommon/llm_services/base_llm.py
Interact.tsx
Guard UI actions based on available datagraphrag-ui/src/components/Interact.tsx
result.edges.result.KnowledgeTablePro.tsx
Add table support for multiple result formatsgraphrag-ui/src/components/tables/KnowledgeTablePro.tsx
final_retrieval(chunk/text) display.agent_graph.py
Robust result handling and empty-result checksgraphrag/app/agent/agent_graph.py
resultinstead ofanswerin context.is_query_result_emptyand gate on non-empty results.result.CustomChatMessage.tsx
Align table visibility with `result`-only datagraphrag-ui/src/components/CustomChatMessage.tsx
resultand exclude history for tables.answerfor table rendering.