You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Here are some key observations to aid the review process:
⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 Security concerns
Remote code execution and credential handling:
The README recommends piping curl to sh and uses -k (TLS verification disabled): curl -k ... | sh. This pattern is vulnerable to MITM and remote code execution. Suggest using a pinned tag/commit with curl -fsSL and explicitly executing a downloaded, verified script.
setup_graphrag_tg.sh writes plaintext database credentials into configs/server_config.json. Consider environment variables, Docker/K8s secrets, or prompting the user to supply them securely.
K8s manifests use hostPath volumes for configs, which is risky in multi-tenant clusters. Prefer ConfigMaps/Secrets and avoid hostPath unless necessary.
Images are pinned to :latest in Compose/K8s, which can lead to supply-chain drift. Recommend pinning immutable digests or versioned tags.
The script references an undefined variable (tg_version) when templating the Docker Compose file and contains an early exit that prevents services from starting. This will break the quickstart path.
curl -s https://raw.githubusercontent.com/tigergraph/graphrag/refs/heads/main/docs/tutorials/docker-compose-tg.yml | sed "s/community:4.2.1/community:${tg_version}/g"> docker-compose.yml
curl -s https://raw.githubusercontent.com/tigergraph/graphrag/refs/heads/main/docs/tutorials/nginx.conf -o configs/nginx.conf
curl -s https://raw.githubusercontent.com/tigergraph/graphrag/refs/heads/main/docs/tutorials/server_config.json | sed '/"gsPort": "14240"/a\ "username": "'${tg_username}'",\ "password": "'${tg_password}'",'| sed "s#http://tigergraph#${tg_host}#g; s/14240/${tg_port}/g"> configs/server_config.json
exitecho"Starting GraphRAG sevices.."
docker compose up -d
sleep 5
The Python version check regex is too strict and likely fails on valid versions, and the log polling looks for "Done" while the grep pattern is "DONE", causing a loop that may never exit. These issues will break the demo flow.
if! python --version 2>&1| grep "Python 3\.1.\.">/dev/null;thenecho"Python 3.11+ is needed, please check Python version or use virutal environment"exit 1
fiif! pip freeze 2>&1| grep pyTigerGraph >/dev/null;thenecho"pyTigerGraph is needed, please install it by running: pip install pyTigerGraph"exit 2
fiecho"Initializing GraphRAG. It may take 5 to 10 minutes."
python ./init_graphrag.py
current_stage=
while:;do
stage=$(docker logs graphrag-ecc 2>&1| grep "Processing Start\|DONE. graphrag.run"| tail -1)if [[ -n"$stage"&&!"$stage"=="$current_stage" ]];thenif [[ "$stage"=~ Processing ]];thenecho$stage| cut -d '' -f5-7
elif [[ "$stage"=~ Done ]];thenecho"GraphRAG initialization is done."breakfifi
current_stage=$stage
sleep 5
done
The tigergraph Deployment/Service and the PVC are created without the graphrag namespace, while the rest of the stack uses it. This cross-namespace mismatch will prevent service discovery (e.g., http://tigergraph) from working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Documentation, Enhancement
Description
Add GraphRAG quickstart scripts and configs
Provide Docker Compose and Kubernetes deployment manifests
Add tutorial notebooks and Python usage examples
Revamp README with setup and LLM configuration
Diagram Walkthrough
File Walkthrough
6 files
Example script to query GraphRAG answersInitialize graph, ingest data, update GraphRAGOverhaul docs with quickstart and configurationEnd-to-end GraphRAG document QA notebookAdjust dataset path in existing notebookAdd sample tutorials JSONL dataset3 files
Setup GraphRAG against existing TigerGraph instanceOne-step local GraphRAG deployment with TigerGraphDemo driver initializes GraphRAG and queries5 files
Kubernetes manifests for GraphRAG stackDocker Compose stack including TigerGraphCompose stack for external TigerGraph deploymentsSample server configuration with LLM settingsNginx reverse proxy for UI and API1 files
Reference to shared tutorials data directory