test: expand zap_widths() test coverage#809
Closed
LeonidasZhak wants to merge 1 commit into
Closed
Conversation
- Add test for labelled vectors (verifies class and labels preserved) - Add test for labelled_spss vectors (verifies na_values preserved) - Add test that other attributes (format.spss, label) are preserved - Add test for data frames with multiple columns - Add test that existing NAs are preserved - Total: 7 tests (was 2)
Author
|
Withdrawing this small automated PR while I consolidate an oversized batch of contributions and reduce maintainer review burden. Sorry for the noise, and thank you for maintaining the project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR expands test coverage for
zap_widths(), which removes thedisplay_widthattribute from vectors. The function had only 2 tests covering basic cases. This PR adds 5 new tests covering edge cases and attribute preservation, bringing the total to 7 tests.Tests added
labelsattribute are preservedna_valuesattribute is preservedformat.spssandlabelattributes remain after zapping widthsValidation
devtools::test(filter = "zap-widths")— all 7 tests passtest-labelled-pillar.R, unrelated)