Fix: export fpc_wsvd generic (urgent, CI red — 2 ERRORs in R CMD check)#288
Merged
Merged
Conversation
PR #280 added an @examples block to man/fpc_wsvd.Rd that calls fpc_wsvd(data, ...) at the user level, but the generic itself was never exported -- only its .matrix and .data.frame methods carried @export tags (registered via S3method() in NAMESPACE). R CMD check --as-cran runs the examples in a fresh session that only sees exported symbols, so 'could not find function fpc_wsvd' aborts the check with 2 ERRORs. One-line @export on the generic + matching export(fpc_wsvd) in NAMESPACE (hand-added; no document() to avoid the roxygen drift churn on ~40 Rd files). https://claude.ai/code/session_01M1QMfji5MpKJvzJYw5Kjb9
Copilot stopped reviewing on behalf of
fabian-s due to an error
June 11, 2026 14:44
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Exports the fpc_wsvd generic so package users can call it directly and so S3 dispatch works from outside the package.
Changes:
- Add roxygen
@exporttag tofpc_wsvddocumentation block. - Add
export(fpc_wsvd)toNAMESPACE.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| R/tfb-fpc-utils.R | Marks fpc_wsvd as exported via roxygen. |
| NAMESPACE | Exposes fpc_wsvd at the package level. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| export(as.tfd_mv) | ||
| export(ensure_list) | ||
| export(fivenum) | ||
| export(fpc_wsvd) |
Comment on lines
+45
to
48
| #' @export | ||
| fpc_wsvd <- function(data, arg, pve = 0.995) { | ||
| UseMethod("fpc_wsvd") | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Urgent — fixes R CMD check ERRORs across the OS matrix.
PR #280 (hygiene A docs) added an
@examplesblock toman/fpc_wsvd.Rdper the original docs hygiene scope (one of the topics flagged as "missing@examples"). The example callsfpc_wsvd(data, ...)at the user level, but the generic itself was never exported — only its.matrixand.data.framemethods carried@exporttags (registered viaS3method()in NAMESPACE).R CMD check --as-cranruns examples in a fresh session that only sees exported symbols, so:aborts the check with 2 ERRORs on every OS matrix entry (macos/ubuntu/windows × release/devel/oldrel-1).
Fix
One-line
@exporton thefpc_wsvdgeneric inR/tfb-fpc-utils.R. NAMESPACE updated by hand-addingexport(fpc_wsvd)(avoiding a fulldocument()run that would churn ~40 unrelated Rd files via roxygen version drift — established pattern across this PR stack).Verified locally:
devtools::load_all(); fpc_wsvdresolves and reportsnamespace:tfbinding.https://claude.ai/code/session_01M1QMfji5MpKJvzJYw5Kjb9
Generated by Claude Code