Refactor floating point comparisons to use epsilon-based functions for improved precision#28
Open
tinboxw wants to merge 1 commit into
Open
Refactor floating point comparisons to use epsilon-based functions for improved precision#28tinboxw wants to merge 1 commit into
tinboxw wants to merge 1 commit into
Conversation
…r improved precision
Owner
|
Can you please provide the inputs and varying platform details? |
|
This seems like a good PR to me. I suggest making some of the functions into methods: specifically
and then the This would slim down the API footprint, which would be easier for users. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the amd64 and arm64 platform architectures, there may be inconsistencies in floating-point comparison calculations. As shown in the following figure, it is the debugging result of the IntersectsSegment function. I took the same input and output different results under different architectures.
I used the epsilon method to solve this problem.
arm64:

amd64:
