Skip to content

[codex] fix Claude model option merging#726

Merged
tiann merged 1 commit into
tiann:mainfrom
flyinghanger:codex/fix-claude-opus-picker
May 29, 2026
Merged

[codex] fix Claude model option merging#726
tiann merged 1 commit into
tiann:mainfrom
flyinghanger:codex/fix-claude-opus-picker

Conversation

@flyinghanger
Copy link
Copy Markdown
Contributor

Summary

  • keep the built-in Claude presets in the composer model picker even when explicit model options are supplied
  • merge non-preset Claude model options as additions instead of letting explicit options replace opus / opus[1m]
  • add regression coverage for Sonnet-only explicit options and model cycling

Fixes #718.

Validation

  • npx --yes bun@1.3.5 run --cwd web test -- AssistantChat/modelOptions.test.ts AssistantChat/claudeModelOptions.test.ts
  • npx --yes bun@1.3.5 run --cwd web typecheck
  • npx --yes bun@1.3.5 run --cwd web build
  • Playwright smoke check against local Vite dev server: Claude options from a Sonnet-only explicit list rendered Default, Sonnet, Sonnet 1M, Opus, and Opus 1M

@flyinghanger flyinghanger marked this pull request as ready for review May 28, 2026 16:47
Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings
No findings.

Summary
Review mode: initial
No issues found in the changed web/src/components/AssistantChat/modelOptions.ts logic. Residual risk: targeted tests could not be executed in this runner because dependencies are not installed.

Testing
Not run (automation): bun is not installed, and npx --yes bun@1.3.5 run --cwd web test -- AssistantChat/modelOptions.test.ts AssistantChat/claudeModelOptions.test.ts failed because vitest is not installed in this checkout.

HAPI Bot

@tiann tiann merged commit 4b4e112 into tiann:main May 29, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug(web): Claude model picker only shows Sonnet; Opus 1M is missing

2 participants