[codex] fix Claude model option merging#726
Merged
Merged
Conversation
There was a problem hiding this comment.
Findings
No findings.
Summary
Review mode: initial
No issues found in the changed web/src/components/AssistantChat/modelOptions.ts logic. Residual risk: targeted tests could not be executed in this runner because dependencies are not installed.
Testing
Not run (automation): bun is not installed, and npx --yes bun@1.3.5 run --cwd web test -- AssistantChat/modelOptions.test.ts AssistantChat/claudeModelOptions.test.ts failed because vitest is not installed in this checkout.
HAPI Bot
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
opus/opus[1m]Fixes #718.
Validation
npx --yes bun@1.3.5 run --cwd web test -- AssistantChat/modelOptions.test.ts AssistantChat/claudeModelOptions.test.tsnpx --yes bun@1.3.5 run --cwd web typechecknpx --yes bun@1.3.5 run --cwd web buildDefault,Sonnet,Sonnet 1M,Opus, andOpus 1M